Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: Source/core/css/mediaControls.css

Issue 1082533002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Google Inc. 3 * Copyright (C) 2009 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 width: 30px; 324 width: 30px;
325 height: 30px; 325 height: 30px;
326 line-height: 30px; 326 line-height: 30px;
327 margin-left: -5px; 327 margin-left: -5px;
328 margin-right: 9px; 328 margin-right: 9px;
329 padding: 0; 329 padding: 0;
330 background-color: initial; 330 background-color: initial;
331 color: inherit; 331 color: inherit;
332 } 332 }
333 333
334 video::-webkit-scrollbar {
335 width: 12px;
336 }
337
338 video::-webkit-scrollbar-track {
339 box-shadow: inset 0 0 6px rgba(20, 20, 20, 0.3);
340 border-radius: 10px;
341 }
342
343 video::-webkit-scrollbar-thumb {
344 border-radius: 10px;
345 background-color: rgba(80, 80, 80, 0.8);
346 box-shadow: inset 0 0 6px rgba(20, 20, 20, 0.5);
347 }
348
349 video::-internal-media-controls-text-track-list {
350 position: absolute;
351 bottom: 35px;
philipj_slow 2015/05/05 14:36:56 You will need to also tweak mediaControlsAndroid.c
srivats 2016/02/23 01:39:26 Will do.
352 right: 5px;
353 background: rgba(20, 20, 20, 0.8);
philipj_slow 2015/05/05 14:36:56 Does background:inherit work, given that the paren
srivats 2016/02/23 01:39:26 The parent is now the enclosure so background:inhe
354 max-width: 50%;
355 max-height: 250px;
philipj_slow 2015/05/05 14:36:56 This means that the list can be bigger than the vi
fs 2015/05/05 15:32:44 Probably because the video element uses LayoutRepl
philipj_slow 2015/05/06 09:28:43 Oh right. I tried display:block too but in hindsig
356 border-radius: 5px;
357 overflow-x: hidden;
358 overflow-y: auto;
359 text-overflow: ellipsis;
360 margin-bottom: 5px;
361 font-family: Arial, Helvetica, sans-serif;
philipj_slow 2015/05/05 14:36:56 Since font-family is inherited, can this be moved
srivats 2016/02/23 01:39:26 Done.
362 white-space: nowrap;
363 display: block;
philipj_slow 2015/05/05 14:36:56 Is display:block needed given that this is already
srivats 2016/02/23 01:39:26 Removed
364 padding: 10px;
365 font-weight: bold;
366 font-size: 16px;
philipj_slow 2015/05/05 14:36:56 I found it a bit jarring that the font size is so
srivats 2016/02/23 01:39:26 Made it the same as the font-size of time display.
367 }
368
369 video::-internal-media-controls-text-track-list-header {
370 margin: 0;
371 text-shadow: 0 1px 0 black;
372 text-align: center;
373 color: gray;
philipj_slow 2015/05/05 14:36:56 I found this rather low contrast, probably not rea
srivats 2016/02/23 01:39:26 Changed it here and in the new material design UI.
374 padding: 4px 0 4px 4px;
375 border-bottom: 1px solid #555;
376 }
377
378 video::-internal-media-controls-text-track-list-item {
379 display: block;
380 color: white;
381 padding: 4px 30px 4px 10px;
382 border-bottom: 1px solid #555;
383 text-align: start;
384 line-height: 25px;
385 }
386
387 video::-internal-media-controls-text-track-list-item:hover {
388 background-color: rgba(105, 105, 105, 0.8);
389 }
390
391 video::-internal-media-controls-text-track-list-item-input {
392 -webkit-appearance: media-track-selection-checkmark;
393 position: relative;
394 visibility: hidden;
395 top: -2px;
philipj_slow 2015/05/05 14:36:56 What's this for? Is the image element misaligned (
srivats 2016/02/23 01:39:26 It looks misaligned without the -2px. Might be an
philipj_slow 2016/03/01 11:21:04 Following up in other CL.
396 left: 0;
397 vertical-align: middle;
398 margin: 0 5px 0 0;
399 width: 25px;
400 height: 25px;
401 }
402
403 video::-internal-media-controls-text-track-list-item-input:checked {
404 visibility: visible;
405 }
406
334 audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-con trols-fullscreen-volume-slider { 407 audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-con trols-fullscreen-volume-slider {
335 display: none; 408 display: none;
336 } 409 }
337 410
338 audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media -controls-fullscreen-volume-min-button { 411 audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media -controls-fullscreen-volume-min-button {
339 display: none; 412 display: none;
340 } 413 }
341 414
342 audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media -controls-fullscreen-volume-max-button { 415 audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media -controls-fullscreen-volume-max-button {
343 display: none; 416 display: none;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 font-weight: bold; 483 font-weight: bold;
411 } 484 }
412 485
413 video::-webkit-media-text-track-container u { 486 video::-webkit-media-text-track-container u {
414 text-decoration: underline; 487 text-decoration: underline;
415 } 488 }
416 489
417 video::-webkit-media-text-track-container i { 490 video::-webkit-media-text-track-container i {
418 font-style: italic; 491 font-style: italic;
419 } 492 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698