Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: Source/core/css/mediaControls.css

Issue 1082533002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Google Inc. 3 * Copyright (C) 2009 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 width: 30px; 323 width: 30px;
324 height: 30px; 324 height: 30px;
325 line-height: 30px; 325 line-height: 30px;
326 margin-left: -5px; 326 margin-left: -5px;
327 margin-right: 9px; 327 margin-right: 9px;
328 padding: 0; 328 padding: 0;
329 background-color: initial; 329 background-color: initial;
330 color: inherit; 330 color: inherit;
331 } 331 }
332 332
333 video::-webkit-media-controls-closed-captions-track-list-container {
334 -webkit-appearance: media-closed-captions-track-list-container;
fs 2015/04/14 12:34:55 I didn't see an appearance implemented for this -
srivats 2015/04/16 23:37:19 Done.
335 position: absolute;
336 display: block;
337 bottom: 30px;
338 background: rgba(20, 20, 20, 0.8);
339 max-width: 50%;
340 max-height: 250px;
341 right: 0;
342 border-radius: 5px;
343 z-index: 1;
fs 2015/04/14 12:34:55 Is this really needed?
srivats 2015/04/16 23:37:19 This wasn't required. I removed it.
344 overflow-x: hidden;
345 overflow-y: auto;
fs 2015/04/14 12:34:56 Have you tested that this works out as expected (a
srivats 2015/04/16 23:37:19 I had tested it earlier but didn't really know how
346 text-overflow: ellipsis;
347 bottom: 100%;
348 margin-bottom: 5px;
349 font-family: Arial, Helvetica, sans-serif;
350 white-space: nowrap;
351 }
352
353 video::-webkit-media-controls-closed-captions-track-list {
354 -webkit-appearance: media-closed-captions-track-list;
355 display: block;
356 max-height: 250px;
fs 2015/04/14 12:34:55 I take it this is supposed to be "10 items", but h
srivats 2015/04/16 23:37:18 Removed this one.
357 text-align: center;
fs 2015/04/14 12:34:55 Is this supposed to affect the header items?
srivats 2015/04/16 23:37:19 Yes it's only for the header. I moved it below.
358 padding: 10px;
359 font-weight: bold;
360 }
361
362 video::-webkit-media-controls-closed-captions-track-list-header {
363 margin: 0;
364 text-shadow: 0 1px 0 black;
365 color: gray;
366 padding: 4px 0 4px 4px;
367 border-bottom: 1px solid #555;
368 font-size: 16px;
369 }
370
371 video::-webkit-media-controls-closed-captions-track-list-item {
372 display: block;
373 color: white;
374 padding: 4px 0 4px 30px;
375 border-bottom: 1px solid #555;
376 font-size: 16px;
fs 2015/04/14 12:34:55 Looks like font-size could be set higher up and in
srivats 2015/04/16 23:37:19 Done.
377 text-align: left;
fs 2015/04/14 12:34:56 Why not just use the default (which will be 'left'
srivats 2015/04/16 23:37:19 Leaving this unspecified actually right aligned th
fs 2015/04/17 11:54:46 Ok, suggest to make this "text-align: start" then
srivats 2015/04/21 01:48:55 Done.
378 position: relative;
379 line-height: 25px;
380 }
381
382 video::-webkit-media-controls-closed-captions-track-list-item:hover {
383 background-color: rgba(105, 105, 105, 0.8);
384 }
385
386 video::-webkit-media-controls-closed-captions-track-list-item-input {
387 -webkit-appearance: media-track-selection-checkmark;
388 position: absolute;
fs 2015/04/14 12:34:55 Do we really need to abspos this?
srivats 2015/04/16 23:37:18 I positioned this absolutely so that the track lab
fs 2015/04/17 11:54:46 I'd prefer a non-abspos version.
srivats 2015/04/21 01:48:55 Done.
389 visibility: none;
fs 2015/04/14 12:34:55 s/none/hidden/
srivats 2015/04/16 23:37:18 Changed visibility to hidden and moved the dimensi
390 top: 4px;
391 left: 0;
392 margin: 0;
393 }
394
395 video::-webkit-media-controls-closed-captions-track-list-item-input:checked {
396 visibility: visible;
fs 2015/04/14 12:34:55 Why not have just the visibility toggle? Do we wan
srivats 2015/04/16 23:37:18 Moved it up.
397 width: 25px;
398 height: 25px;
399 }
400
333 audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-con trols-fullscreen-volume-slider { 401 audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-con trols-fullscreen-volume-slider {
334 display: none; 402 display: none;
335 } 403 }
336 404
337 audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media -controls-fullscreen-volume-min-button { 405 audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media -controls-fullscreen-volume-min-button {
338 display: none; 406 display: none;
339 } 407 }
340 408
341 audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media -controls-fullscreen-volume-max-button { 409 audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media -controls-fullscreen-volume-max-button {
342 display: none; 410 display: none;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 font-weight: bold; 477 font-weight: bold;
410 } 478 }
411 479
412 video::-webkit-media-text-track-container u { 480 video::-webkit-media-text-track-container u {
413 text-decoration: underline; 481 text-decoration: underline;
414 } 482 }
415 483
416 video::-webkit-media-text-track-container i { 484 video::-webkit-media-text-track-container i {
417 font-style: italic; 485 font-style: italic;
418 } 486 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698