DescriptionRevert of Simplify mojo_shell since it's now only used for Mandoline. (patchset #6 id:100001 of https://codereview.chromium.org/1057603003/)
Reason for revert:
This CL causes problems for application testing:
1) Removing url-mappings breaks the ability to mock out service dependencies of test applications.
2) We want to connect directly to the test applications specified on the command line, not mojo:window_manager for apptests.
3) The apptest_runner.py currently uses --args-for, but that doesn't matter so much...
I've started working around these issues in WIP a CL, <https://codereview.chromium.org/1070463003/>, but it would be better to not let this CL bake if we go intend to revert some of its behavior changes.
Original issue's description:
> Simplify mojo_shell since it's now only used for Mandoline.
>
> -no need to map kiosk_wm to window_manager, instead, make kiosk_wm's binary output be window_manager.mojom
> -no need for app-specific args, instead use base::CommandLine. This is important for Mandoline since we'll be sharing code with Chrome which does use these flags.
> -mojo_shell url is enough to start a browser now
>
> Committed: https://crrev.com/143eb32f63bd929f7d730970e2477804f318a7eb
> Cr-Commit-Position: refs/heads/master@{#324579}
TBR=ben@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/f1d1609fce75c570455aaa526f6023ea97a80c0d
Cr-Commit-Position: refs/heads/master@{#324712}
Patch Set 1 #Patch Set 2 : Manual revert #Patch Set 3 : Sync and rebase. #
Messages
Total messages: 15 (6 generated)
|