Use the Clang plugin on Windows.

Use the Clang plugin on Windows.

BUG=467287
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/2fcc20f4d2d51a8527af2f0f1dbe0a8bd6fb6809

[dcheng, 2015-04-10 22:35:23]

dcheng@chromium.org changed reviewers:
+ hans@chromium.org, thakis@chromium.org

[dcheng, 2015-04-10 22:35:23]

I present this patch for some gyp fun.

It is not landable. There are way too many errors triggered by system headers.

[hans, 2015-04-11 12:00:30]

> It is not landable. There are way too many errors triggered by system headers.

Does the plugin not try to suppress warnings from system headers? Maybe we can
just update that to work on Windows?

https://codereview.chromium.org/1082503002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1082503002/diff/1/build/common.gypi#newcode2190
build/common.gypi:2190: 'clang_dynlib_flags%': '',
Probably worth a comment that the plugins are linked in on Windows, so no need
to load them dynamically.

[dcheng, 2015-04-11 19:27:24]

Yeah, I was figuring out the best way to do the ignored paths on Windows. I've
updated https://codereview.chromium.org/1072203002 to include the updated logic
for ignoring system headers.

https://codereview.chromium.org/1082503002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1082503002/diff/1/build/common.gypi#newcode2190
build/common.gypi:2190: 'clang_dynlib_flags%': '',
On 2015/04/11 12:00:30, hans wrote:
> Probably worth a comment that the plugins are linked in on Windows, so no need
> to load them dynamically.

Yeah, that's a good idea. Done.

[dcheng, 2015-04-16 17:13:49]

PTAL. I fixed some gyp errors and threw in GN too (because why not). That being
said, it seems like GN+clang on win isn't really a supported config yet =)

[Nico, 2015-04-16 17:17:38]

lgtm, sweet!

[commit-bot: I haz the power, 2015-04-16 17:31:00]

Patchset 4 (id:??) landed as
https://crrev.com/2fcc20f4d2d51a8527af2f0f1dbe0a8bd6fb6809
Cr-Commit-Position: refs/heads/master@{#325465}

[dcheng, 2015-04-16 17:31:14]

Committed patchset #4 (id:60001) manually as
2fcc20f4d2d51a8527af2f0f1dbe0a8bd6fb6809 (presubmit successful).