Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: sync/internal_api/public/util/sync_string_conversions.cc

Issue 10824410: [Sync] Refactor passphrase state handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/util/sync_string_conversions.cc
diff --git a/sync/internal_api/public/util/sync_string_conversions.cc b/sync/internal_api/public/util/sync_string_conversions.cc
index 9614203ad140414712eb9ad0fe09a4c2eef69056..7e404b77b4864e0994450937fd79624fae4a7fe1 100644
--- a/sync/internal_api/public/util/sync_string_conversions.cc
+++ b/sync/internal_api/public/util/sync_string_conversions.cc
@@ -4,16 +4,15 @@
#include "sync/internal_api/public/util/sync_string_conversions.h"
+#define ENUM_CASE(x) case x: return #x
+
namespace syncer {
const char* ConnectionStatusToString(ConnectionStatus status) {
switch (status) {
- case CONNECTION_OK:
- return "CONNECTION_OK";
- case CONNECTION_AUTH_ERROR:
- return "CONNECTION_AUTH_ERROR";
- case CONNECTION_SERVER_ERROR:
- return "CONNECTION_SERVER_ERROR";
+ ENUM_CASE(CONNECTION_OK);
+ ENUM_CASE(CONNECTION_AUTH_ERROR);
+ ENUM_CASE(CONNECTION_SERVER_ERROR);
default:
NOTREACHED();
return "INVALID_CONNECTION_STATUS";
@@ -24,16 +23,25 @@ const char* ConnectionStatusToString(ConnectionStatus status) {
const char* PassphraseRequiredReasonToString(
PassphraseRequiredReason reason) {
switch (reason) {
- case REASON_PASSPHRASE_NOT_REQUIRED:
- return "REASON_PASSPHRASE_NOT_REQUIRED";
- case REASON_ENCRYPTION:
- return "REASON_ENCRYPTION";
- case REASON_DECRYPTION:
- return "REASON_DECRYPTION";
+ ENUM_CASE(REASON_PASSPHRASE_NOT_REQUIRED);
+ ENUM_CASE(REASON_ENCRYPTION);
+ ENUM_CASE(REASON_DECRYPTION);
default:
NOTREACHED();
return "INVALID_REASON";
}
}
+const char* PassphraseStateToString(PassphraseState state) {
+ switch (state) {
+ ENUM_CASE(IMPLICIT_PASSPHRASE);
+ ENUM_CASE(KEYSTORE_PASSPHRASE);
+ ENUM_CASE(FROZEN_IMPLICIT_PASSPHRASE);
+ ENUM_CASE(CUSTOM_PASSPHRASE);
+ default:
+ NOTREACHED();
+ return "INVALID_PASSPHRASE_STATE";
+ }
+}
+
} // namespace syncer
« no previous file with comments | « sync/internal_api/public/util/sync_string_conversions.h ('k') | sync/internal_api/sync_encryption_handler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698