Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: sync/syncable/directory.h

Issue 1082423002: [Sync] Make DirectoryBackingStore's db_ private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move friend declarations to private section. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/syncable/deferred_on_disk_directory_backing_store.cc ('k') | sync/syncable/directory_backing_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/directory.h
diff --git a/sync/syncable/directory.h b/sync/syncable/directory.h
index 9bf90c1d865dbfba29ff6e50e288d509cd46c789..9d66b81f15c14cafb01d21d37879db3c62c56b84 100644
--- a/sync/syncable/directory.h
+++ b/sync/syncable/directory.h
@@ -55,16 +55,6 @@ enum InvariantCheckLevel {
// Although Directory's kernel_ is exposed via public accessor it should be
// treated as pseudo-private.
class SYNC_EXPORT Directory {
- friend class SyncableDirectoryTest;
- friend class syncer::TestUserShare;
- FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest, ManageDeleteJournals);
- FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest,
- TakeSnapshotGetsAllDirtyHandlesTest);
- FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest,
- TakeSnapshotGetsOnlyDirtyHandlesTest);
- FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest,
- TakeSnapshotGetsMetahandlesToPurge);
-
public:
typedef std::vector<int64> Metahandles;
@@ -540,6 +530,16 @@ class SYNC_EXPORT Directory {
const Kernel* kernel() const;
private:
+ friend class SyncableDirectoryTest;
+ friend class syncer::TestUserShare;
+ FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest, ManageDeleteJournals);
+ FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest,
+ TakeSnapshotGetsAllDirtyHandlesTest);
+ FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest,
+ TakeSnapshotGetsOnlyDirtyHandlesTest);
+ FRIEND_TEST_ALL_PREFIXES(SyncableDirectoryTest,
+ TakeSnapshotGetsMetahandlesToPurge);
+
// You'll notice that some of the methods below are private overloads of the
// public ones declared above. The general pattern is that the public overload
// constructs a ScopedKernelLock before calling the corresponding private
« no previous file with comments | « sync/syncable/deferred_on_disk_directory_backing_store.cc ('k') | sync/syncable/directory_backing_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698