sync/syncable/on_disk_directory_backing_store.cc - Issue 1082423002: [Sync] Make DirectoryBackingStore's db_ private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/on_disk_directory_backing_store.cc

Issue 1082423002: [Sync] Make DirectoryBackingStore's db_ private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/syncable/on_disk_directory_backing_store.cc

diff --git a/sync/syncable/on_disk_directory_backing_store.cc b/sync/syncable/on_disk_directory_backing_store.cc

index f369e9360bc952ff835cdf3418af128c63d7aea1..e6f284d3dd66b80332b839261913488ae95872fc 100644

--- a/sync/syncable/on_disk_directory_backing_store.cc

+++ b/sync/syncable/on_disk_directory_backing_store.cc

@@ -38,8 +38,9 @@ DirOpenResult OnDiskDirectoryBackingStore::TryLoad(

MetahandleSet* metahandles_to_purge,

Directory::KernelLoadInfo* kernel_load_info) {

DCHECK(CalledOnValidThread());

- if (!db_->is_open()) {

- if (!db_->Open(backing_filepath_))

+ if (!IsOpen()) {

+ if (!Open(backing_filepath_))

return FAILED_OPEN_DATABASE;

}