Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: sync/syncable/directory_backing_store.cc

Issue 1082423002: [Sync] Make DirectoryBackingStore's db_ private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/syncable/directory_backing_store.cc
diff --git a/sync/syncable/directory_backing_store.cc b/sync/syncable/directory_backing_store.cc
index 6bcb96ec78143fbbc76c0e406d3d509e83129f1c..d6cb0e6c157d6053f6566dd3e7b2ae9ff9e00214 100644
--- a/sync/syncable/directory_backing_store.cc
+++ b/sync/syncable/directory_backing_store.cc
@@ -206,9 +206,9 @@ DirectoryBackingStore::DirectoryBackingStore(const string& dir_name)
DirectoryBackingStore::DirectoryBackingStore(const string& dir_name,
sql::Connection* db)
- : db_(db),
- dir_name_(dir_name),
+ : dir_name_(dir_name),
database_page_size_(IsSyncBackingDatabase32KEnabled() ? 32768 : 4096),
+ db_(db),
needs_column_refresh_(false) {
DCHECK(base::ThreadTaskRunnerHandle::IsSet());
}
@@ -334,6 +334,24 @@ bool DirectoryBackingStore::SaveChanges(
return transaction.Commit();
}
+sql::Connection* DirectoryBackingStore::db() {
+ return db_.get();
+}
+
+bool DirectoryBackingStore::IsOpen() const {
+ return db_->is_open();
+}
+
+bool DirectoryBackingStore::Open(const base::FilePath& path) {
+ DCHECK(!db_->is_open());
+ return db_->Open(path);
+}
+
+bool DirectoryBackingStore::OpenInMemory() {
+ DCHECK(!db_->is_open());
+ return db_->OpenInMemory();
+}
+
bool DirectoryBackingStore::InitializeTables() {
int page_size = 0;
if (IsSyncBackingDatabase32KEnabled() && GetDatabasePageSize(&page_size) &&

Powered by Google App Engine
This is Rietveld 408576698