Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10824112: Move Chrome OS device settings stuff to chrome/browser/chromeos/settings. (Closed)

Created:
8 years, 4 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move Chrome OS device settings stuff to chrome/browser/chromeos/settings. BUG=chromium:139126 TEST=Still compiles and passes tests, no functional changes. TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149399

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -6438 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/cros_settings.h View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/chromeos/cros_settings.cc View 1 chunk +0 lines, -315 lines 0 comments Download
D chrome/browser/chromeos/cros_settings_names.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/chromeos/cros_settings_names.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/chromeos/cros_settings_provider.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/chromeos/cros_settings_provider.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/chromeos/cros_settings_unittest.cc View 1 chunk +0 lines, -276 lines 0 comments Download
D chrome/browser/chromeos/device_settings_provider.h View 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/browser/chromeos/device_settings_provider.cc View 1 chunk +0 lines, -748 lines 0 comments Download
D chrome/browser/chromeos/device_settings_provider_unittest.cc View 1 chunk +0 lines, -257 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/login/mock_owner_key_utils.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/chromeos/login/mock_owner_key_utils.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/chromeos/login/mock_ownership_service.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/chromeos/login/mock_ownership_service.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/chromeos/login/mock_signed_settings_helper.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/chromeos/login/mock_signed_settings_helper.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/chromeos/login/owner_key_utils.h View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/browser/chromeos/login/owner_key_utils.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/chromeos/login/owner_key_utils_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/chromeos/login/owner_manager.h View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/chromeos/login/owner_manager.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/chromeos/login/owner_manager_unittest.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/chromeos/login/owner_manager_unittest.cc View 1 chunk +0 lines, -347 lines 0 comments Download
D chrome/browser/chromeos/login/ownership_service.h View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/chromeos/login/ownership_service.cc View 1 chunk +0 lines, -259 lines 0 comments Download
D chrome/browser/chromeos/login/ownership_service_unittest.cc View 1 chunk +0 lines, -238 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/session_manager_observer.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/chromeos/login/session_manager_observer.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings.h View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings.cc View 1 chunk +0 lines, -290 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings_cache.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings_cache.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings_cache_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings_helper.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings_helper.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings_helper_unittest.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D chrome/browser/chromeos/login/signed_settings_unittest.cc View 1 chunk +0 lines, -398 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/settings/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/settings/cros_settings.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/cros_settings.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/cros_settings_names.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/settings/cros_settings_names.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/settings/cros_settings_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/settings/cros_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/settings/cros_settings_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/device_settings_provider.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/chromeos/settings/device_settings_provider.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/device_settings_provider_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/mock_owner_key_utils.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/mock_owner_key_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/mock_ownership_service.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/mock_ownership_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/mock_signed_settings_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/mock_signed_settings_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/owner_key_utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/owner_key_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/settings/owner_key_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/settings/owner_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/owner_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/owner_manager_unittest.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/owner_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/ownership_service.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/ownership_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/ownership_service_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/session_manager_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/settings/session_manager_observer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_cache.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_cache_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_helper_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_migration_helper.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_migration_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/signed_settings_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/settings/stub_cros_settings_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/stub_cros_settings_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/settings/system_settings_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/settings/system_settings_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/signed_settings_migration_helper.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/chromeos/signed_settings_migration_helper.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/chromeos/stub_cros_settings_provider.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/stub_cros_settings_provider.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/chromeos/stub_cros_settings_provider_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/chromeos/system_settings_provider.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/chromeos/system_settings_provider.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/browser/policy/app_pack_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/device_policy_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_status_collector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_status_collector_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/accounts_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 7 chunks +28 lines, -28 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 4 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mattias Nissler (ping if slow)
Just a mechanic move, no functional changes.
8 years, 4 months ago (2012-07-31 15:17:45 UTC) #1
Nikita (slow)
rubber stamp lgtm
8 years, 4 months ago (2012-07-31 16:14:56 UTC) #2
pastarmovj
Tough one! :) LGTM
8 years, 4 months ago (2012-08-01 08:19:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/10824112/1
8 years, 4 months ago (2012-08-01 08:21:19 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/login/wallpaper_manager.cc: While running patch -p1 --forward --force; patching file chrome/browser/chromeos/login/wallpaper_manager.cc ...
8 years, 4 months ago (2012-08-01 08:21:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/10824112/134
8 years, 4 months ago (2012-08-01 09:31:56 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 11:31:37 UTC) #7 
Change committed as 149399

Powered by Google App Engine
This is Rietveld 408576698