Enables V8 integration with the Intel VTune performance analysis tool. This allows the VTune profi…

src/mark-compact.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 671 matching lines @@
 #ifdef DEBUG
   ASSERT(state_ == IDLE);
   state_ = PREPARE_GC;
 #endif
 
   ASSERT(!FLAG_never_compact || !FLAG_always_compact);
 
 #ifdef ENABLE_GDB_JIT_INTERFACE
   if (FLAG_gdbjit) {
     // If GDBJIT interface is active disable compaction.
-    compacting_collection_ = false;
+    compacting_ = false;
   }
 #endif
+// For now, set compacting to false when vtune is running.
+// Ideally we want to communicate the code movement.
+if (VTUNERUNNING)
+  compacting_ = false;

[danno, 2012/08/02 12:38:11]

Can you extend siggi's SetJitCodeEventHandler API to take a "flags" argument,
where the flags are boolean flags, one being
"JIT_CODE_HANDLER_SUPPORTS_MOVED_CODE". If this flag is not set when the handler
is installed, then compacting_ is false (doesn't need to be conditional

 
   // Clear marking bits if incremental marking is aborted.
   if (was_marked_incrementally_ && abort_incremental_marking_) {
     heap()->incremental_marking()->Abort();
     ClearMarkbits();
     AbortCompaction();
     was_marked_incrementally_ = false;
   }
 
   // Don't start compaction if we are in the middle of incremental
@@ skipping 3574 matching lines @@
   while (buffer != NULL) {
     SlotsBuffer* next_buffer = buffer->next();
     DeallocateBuffer(buffer);
     buffer = next_buffer;
   }
   *buffer_address = NULL;
 }
 
 
 } }  // namespace v8::internal