Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Issue 1082363004: DevTools: kill codeschool extension from whitelist (Closed)

Created:
5 years, 8 months ago by lushnikov
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: kill codeschool extension from whitelist This patch removes "Discover DevTools Companion" chrome extension from whitelist. R=pfeldman, paulirish Committed: https://crrev.com/25a6650258dcbcc1d03ed9ed09de123910659613 Cr-Commit-Position: refs/heads/master@{#326601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
lushnikov
PTAL. Note that this will make "DevTools Companion" unusable; we should notify them first and ...
5 years, 8 months ago (2015-04-20 10:22:21 UTC) #1
paulirish
lgtm. notifying them today. okay for breaking canary (more) for now. https://github.com/GoogleChrome/devtools-docs/issues/211#issuecomment-69979262 summarizes the current ...
5 years, 8 months ago (2015-04-23 17:00:32 UTC) #2
pfeldman
lgtm
5 years, 8 months ago (2015-04-23 17:06:46 UTC) #3
lushnikov
kalman@chromium.org: Please take a look
5 years, 8 months ago (2015-04-23 17:07:36 UTC) #5
not at google - send to devlin
lgtm, but double check that's the only place the whitelist occurs. sometimes the IDs are ...
5 years, 8 months ago (2015-04-23 17:41:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082363004/1
5 years, 8 months ago (2015-04-23 18:00:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 19:08:14 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 19:09:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25a6650258dcbcc1d03ed9ed09de123910659613
Cr-Commit-Position: refs/heads/master@{#326601}

Powered by Google App Engine
This is Rietveld 408576698