chrome/browser/plugin_installer.cc - Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_installer.cc

Issue 10823434: [6] Moves CreateVersionFromString to plugin_utils and updates the callers. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressing jam@'s review comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/hang_monitor/hung_plugin_action.cc ('k') | content/browser/plugin_data_remover_impl.cc » ('j') | webkit/plugins/npapi/plugin_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugin_installer.cc

diff --git a/chrome/browser/plugin_installer.cc b/chrome/browser/plugin_installer.cc

index bcfbecc28a1c8ec5f3d6f4e161b6d66bd7c8f229..360094ee4162251debb5983fd084a998868f8035 100644

--- a/chrome/browser/plugin_installer.cc

+++ b/chrome/browser/plugin_installer.cc

@@ -26,7 +26,8 @@

#include "content/public/browser/resource_dispatcher_host.h"

#include "content/public/browser/web_contents.h"

#include "net/url_request/url_request.h"

-#include "webkit/plugins/npapi/plugin_group.h"

+#include "webkit/plugins/npapi/plugin_utils.h"

+#include "webkit/plugins/webplugininfo.h"

using content::BrowserContext;

using content::BrowserThread;

@@ -97,7 +98,7 @@ PluginInstaller::SecurityStatus PluginInstaller::GetSecurityStatus(

return SECURITY_STATUS_REQUIRES_AUTHORIZATION;

Version version;

- webkit::npapi::PluginGroup::CreateVersionFromString(plugin.version, &version);

+ webkit::npapi::CreateVersionFromString(plugin.version, &version);

if (!version.IsValid())

version = Version("0");

« no previous file with comments | « chrome/browser/hang_monitor/hung_plugin_action.cc ('k') | content/browser/plugin_data_remover_impl.cc » ('j') | webkit/plugins/npapi/plugin_utils.h » ('J')