Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1082333004: fixes #145, optional params+initializing formals+private fields (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #145, optional params+initializing formals+private fields R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9d47ccca62e0165afe60370e9cd9743ca995c4ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M test/codegen/expect/temps.js View 1 chunk +16 lines, -0 lines 0 comments Download
M test/codegen/temps.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 8 months ago (2015-04-21 21:31:04 UTC) #2
vsm
lgtm
5 years, 8 months ago (2015-04-21 22:06:28 UTC) #3
Jennifer Messerly
5 years, 8 months ago (2015-04-21 22:28:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d47ccca62e0165afe60370e9cd9743ca995c4ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698