Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: tools/mb/mb.py

Issue 1082323004: Make sure 'mb analyze' handles "all" correctly as a target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch for landing Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/mb/mb_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index 5d7ffe0206d1e2fd50e6a652d423315d6f97c36c..5d6fe1b7e075184d96532d8343e56d51fe8e4e77 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -416,6 +416,14 @@ class MetaBuildWrapper(object):
self.WriteJSON({'status': 'Found dependency (all)'}, output_path)
return 0
+ # TODO: Because of the --type=executable filter below, we don't detect
+ # when files will cause 'all' or 'gn_all' or similar targets to be
+ # dirty. We need to figure out how to handle that properly, but for
+ # now we can just bail out early.
+ if 'gn_all' in inp['targets'] or 'all' in inp['targets']:
+ self.WriteJSON({'status': 'Found dependency (all)'}, output_path)
+ return 0
+
all_needed_targets = set()
ret = 0
for f in inp['files']:
« no previous file with comments | « no previous file | tools/mb/mb_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698