Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: appengine/cr-buildbucket/test/api_test.py

Issue 1082303002: buildbucket: put_batch endpoint (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/cr-buildbucket/test/api_test.py
diff --git a/appengine/cr-buildbucket/test/api_test.py b/appengine/cr-buildbucket/test/api_test.py
index dca6f417f44192f31c5fbe0ceb093b3c8ff853d6..f3c49140d3030d3d61f64b44fdd1011d435a6dc3 100644
--- a/appengine/cr-buildbucket/test/api_test.py
+++ b/appengine/cr-buildbucket/test/api_test.py
@@ -78,7 +78,7 @@ class BuildBucketApiTest(testing.EndpointsTestCase):
##################################### PUT ####################################
def test_put(self):
- self.test_build.tags = ['owner=ivan']
+ self.test_build.tags = ['owner:ivan']
self.service.add.return_value = self.test_build
req = {
'bucket': self.test_build.bucket,
@@ -131,6 +131,49 @@ class BuildBucketApiTest(testing.EndpointsTestCase):
}
self.expect_error('put', req, 'INVALID_INPUT')
+ ################################## PUT_BATCH #################################
+
+ def test_put_batch(self):
+ self.test_build.tags = ['owner:ivan']
+ build2 = model.Build(bucket='v8')
+ build2.put()
+ self.service.add_batch.return_value = [self.test_build, build2]
+ req = {
+ 'builds': [
+ {
+ 'bucket': self.test_build.bucket,
+ 'tags': self.test_build.tags,
+ },
+ {
+ 'bucket': build2.bucket,
+ },
+ ],
+ }
+ resp = self.call_api('put_batch', req).json_body
+ self.service.add_batch.assert_called_once_with([
+ {
+ 'bucket': self.test_build.bucket,
+ 'tags': self.test_build.tags,
+ 'parameters': None,
+ 'lease_expiration_date': None,
+ },
+ {
+ 'bucket': build2.bucket,
+ 'tags': [],
+ 'parameters': None,
+ 'lease_expiration_date': None,
+ },
+ ])
+
+ res_build0 = resp['builds'][0]
+ self.assertEqual(res_build0['id'], str(self.test_build.key.id()))
+ self.assertEqual(res_build0['bucket'], self.test_build.bucket)
+ self.assertEqual(res_build0['tags'], self.test_build.tags)
+
+ res_build1 = resp['builds'][1]
+ self.assertEqual(res_build1['id'], str(self.test_build.key.id()))
+ self.assertEqual(res_build1['bucket'], build2.bucket)
+
#################################### SEARCH ##################################
def test_search(self):

Powered by Google App Engine
This is Rietveld 408576698