buildbucket: put_batch endpoint

appengine/cr-buildbucket/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import functools
 import json
 import logging
 
 from components import auth
@@ skipping 25 matching lines @@
     errors.InvalidBuildStateError: ErrorReason.INVALID_BUILD_STATE,
     errors.BuildIsCompletedError: ErrorReason.BUILD_IS_COMPLETED,
 }
 
 
 class ErrorMessage(messages.Message):
   reason = messages.EnumField(ErrorReason, 1, required=True)
   message = messages.StringField(2, required=True)
 
 
+def exception_to_error_message(ex):
+  assert isinstance(ex, errors.Error)
+  return ErrorMessage(
+      reason=ERROR_REASON_MAP[type(ex)],
+      message=ex.message,
+  )
+
+
+class PutRequestMessage(messages.Message):
+  bucket = messages.StringField(1, required=True)
+  tags = messages.StringField(2, repeated=True)
+  parameters_json = messages.StringField(3)
+  lease_expiration_ts = messages.IntegerField(4)
+
+
 class BuildMessage(messages.Message):
   """Describes model.Build, see its docstring."""
   id = messages.IntegerField(1, required=True)
   bucket = messages.StringField(2, required=True)
   tags = messages.StringField(3, repeated=True)
   parameters_json = messages.StringField(4)
   status = messages.EnumField(model.BuildStatus, 5)
   result = messages.EnumField(model.BuildResult, 6)
   result_details_json = messages.StringField(7)
   failure_reason = messages.EnumField(model.FailureReason, 8)
@@ skipping 93 matching lines @@
   endpoints_decorator = auth.endpoints_method(
       request_message_class, response_message_class, **kwargs)
 
   def decorator(fn):
     @functools.wraps(fn)
     def decorated(*args, **kwargs):
       try:
         return fn(*args, **kwargs)
       except errors.Error as ex:
         assert hasattr(response_message_class, 'error')
-        return response_message_class(error=ErrorMessage(
-            reason=ERROR_REASON_MAP[type(ex)],
-            message=ex.message,
-        ))
+        return response_message_class(error=exception_to_error_message(ex))
     return endpoints_decorator(decorated)
   return decorator
 
 
 def parse_json(json_data, param_name):
   if not json_data:
     return None
   try:
     return json.loads(json_data)
   except ValueError as ex:
@@ skipping 38 matching lines @@
       path='builds/{id}', http_method='GET')
   def get(self, request):
     """Returns a build by id."""
     build = self.service.get(request.id)
     if build is None:
       raise errors.BuildNotFoundError()
     return build_to_response_message(build)
 
   ###################################  PUT  ####################################
 
-  class PutRequestMessage(messages.Message):
-    bucket = messages.StringField(1, required=True)
-    tags = messages.StringField(2, repeated=True)
-    parameters_json = messages.StringField(3)
-    lease_expiration_ts = messages.IntegerField(4)
-
   @buildbucket_api_method(
       PutRequestMessage, BuildResponseMessage,
       path='builds', http_method='PUT')
   def put(self, request):
     """Creates a new build."""
-    if not request.bucket:
-      raise errors.InvalidInputError('Bucket not specified')
-
     build = self.service.add(
         bucket=request.bucket,
         tags=request.tags,
         parameters=parse_json(request.parameters_json, 'parameters_json'),
         lease_expiration_date=parse_datetime(request.lease_expiration_ts),
     )
     return build_to_response_message(build, include_lease_key=True)
 
+  ################################  PUT_BATCH  #################################
+
+  class PutBatchRequestMessage(messages.Message):
+    builds = messages.MessageField(PutRequestMessage, 1, repeated=True)
+
+  class PutBatchResponseMessage(messages.Message):
+    builds = messages.MessageField(BuildMessage, 1, repeated=True)
+    error = messages.MessageField(ErrorMessage, 2)
+
+  @buildbucket_api_method(
+      PutBatchRequestMessage, PutBatchResponseMessage,
+      path='builds/batch', http_method='PUT')
+  def put_batch(self, request):

[Vadim Sh., 2015/04/14 18:56:40]

btw, apiary APIs exposed by Google support batching automagically on Endpoints
level, e.g. https://cloud.google.com/compute/docs/api/how-tos/batch

Maybe Cloud Endpoints can do it too?..

[nodir, 2015/04/14 22:13:05]

It cannot

+    """Creates up to 25 new builds transactionally."""
+    builds = self.service.add_batch([
+        {
+            'bucket': build_req.bucket,
+            'tags': build_req.tags,
+            'parameters': parse_json(
+                build_req.parameters_json, 'parameters_json'),
+            'lease_expiration_date': parse_datetime(
+                build_req.lease_expiration_ts),
+        }
+        for build_req in request.builds
+    ])
+    return self.PutBatchResponseMessage(
+        builds=[build_to_message(b, include_lease_key=True) for b in builds],
+    )
+
+
   ##################################  SEARCH   #################################
 
   SEARCH_REQUEST_RESOURCE_CONTAINER = endpoints.ResourceContainer(
       message_types.VoidMessage,
       start_cursor=messages.StringField(1),
       # All specified tags must be present in a build.
       bucket=messages.StringField(2, repeated=True),
       tag=messages.StringField(3, repeated=True),
       status=messages.EnumField(model.BuildStatus, 4),
       result=messages.EnumField(model.BuildResult, 5),
@@ skipping 259 matching lines @@
         rules=[
             acl.Rule(
                 role=rule.role,
                 group=rule.group,
             )
             for rule in request.rules
         ],
     )
     bucket_acl = acl.set_acl(request.bucket, bucket_acl)
     return bucket_acl_to_response_message(bucket_acl)