buildbucket: put_batch endpoint

appengine/cr-buildbucket/test/api_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import httplib
 import json
 import mock
 
 from components import auth
@@ skipping 60 matching lines @@
     self.assertEqual(
         resp['build']['parameters_json'], '{"buildername": "linux_rel"}')
 
   def test_get_nonexistent_build(self):
     self.service.get.return_value = None
     self.expect_error('get', {'id': 1}, 'BUILD_NOT_FOUND')
 
   ##################################### PUT ####################################
 
   def test_put(self):
-    self.test_build.tags = ['owner=ivan']
+    self.test_build.tags = ['owner:ivan']
     self.service.add.return_value = self.test_build
     req = {
         'bucket': self.test_build.bucket,
         'tags': self.test_build.tags,
     }
     resp = self.call_api('put', req).json_body
     self.service.add.assert_called_once_with(
         bucket=self.test_build.bucket,
         tags=req['tags'],
         parameters=None,
         lease_expiration_date=None,
+        client_operation_id=None,
     )
     self.assertEqual(resp['build']['id'], str(self.test_build.key.id()))
     self.assertEqual(resp['build']['bucket'], req['bucket'])
     self.assertEqual(resp['build']['tags'], req['tags'])
 
   def test_put_with_parameters(self):
     self.service.add.return_value = self.test_build
     req = {
         'bucket': self.test_build.bucket,
         'parameters_json': json.dumps(self.test_build.parameters),
     }
     resp = self.call_api('put', req).json_body
     self.assertEqual(resp['build']['parameters_json'], req['parameters_json'])
 
   def test_put_with_leasing(self):
     self.test_build.lease_expiration_date = self.future_date
     self.service.add.return_value = self.test_build
     req = {
         'bucket': self.test_build.bucket,
         'lease_expiration_ts': self.future_ts,
     }
     resp = self.call_api('put', req).json_body
     self.service.add.assert_called_once_with(
         bucket=self.test_build.bucket,
         tags=[],
         parameters=None,
         lease_expiration_date=self.future_date,
+        client_operation_id=None,
     )
     self.assertEqual(
         resp['build']['lease_expiration_ts'], req['lease_expiration_ts'])
 
-  def test_put_with_empty_bucket(self):
-    self.expect_error('put', {'bucket': ''}, 'INVALID_INPUT')
-
   def test_put_with_malformed_parameters_json(self):
     req = {
         'bucket':'chromium',
         'parameters_json': '}non-json',
     }
     self.expect_error('put', req, 'INVALID_INPUT')
 
+  ################################## PUT_BATCH #################################
+
+  def test_put_batch(self):
+    self.test_build.tags = ['owner:ivan']
+    build1_future = ndb.Future()
+    build1_future.set_result(self.test_build)
+
+    build2 = model.Build(id=2, bucket='v8')
+    build2_future = ndb.Future()
+    build2_future.set_result(build2)
+
+    bad_build_future = ndb.Future()
+    bad_build_future.set_exception(errors.InvalidInputError('Just bad'))
+
+    self.service.add_async.side_effect = [
+        build1_future, build2_future, bad_build_future]
+    req = {
+        'builds': [
+            {
+                'bucket': self.test_build.bucket,
+                'tags': self.test_build.tags,
+                'client_operation_id': '0',
+            },
+            {
+                'bucket': build2.bucket,
+                'client_operation_id': '1',
+            },
+            {
+                'bucket': 'bad name',
+                'client_operation_id': '2',
+            },
+        ],
+    }
+    resp = self.call_api('put_batch', req).json_body
+    self.service.add_async.assert_any_call(
+        bucket=self.test_build.bucket,
+        tags=self.test_build.tags,
+        parameters=None,
+        lease_expiration_date=None,
+        client_operation_id='0',
+    )
+    self.service.add_async.assert_any_call(
+        bucket=build2.bucket,
+        tags=[],
+        parameters=None,
+        lease_expiration_date=None,
+        client_operation_id='1',
+    )
+
+    res0 = resp['results'][0]
+    self.assertEqual(res0['client_operation_id'], '0')
+    self.assertEqual(res0['build']['id'], str(self.test_build.key.id()))
+    self.assertEqual(res0['build']['bucket'], self.test_build.bucket)
+    self.assertEqual(res0['build']['tags'], self.test_build.tags)
+
+    res1 = resp['results'][1]
+    self.assertEqual(res1['client_operation_id'], '1')
+    self.assertEqual(res1['build']['id'], str(build2.key.id()))
+    self.assertEqual(res1['build']['bucket'], build2.bucket)
+
+    res2 = resp['results'][2]
+    self.assertEqual(res2, {
+        'client_operation_id': '2',
+        'error': {'reason': 'INVALID_INPUT', 'message': 'Just bad'},
+    })
+
   #################################### SEARCH ##################################
 
   def test_search(self):
     self.test_build.put()
     self.service.search.return_value = ([self.test_build], 'the cursor')
     req = {
         'bucket': ['chromium'],
         'cancelation_reason': 'CANCELED_EXPLICITLY',
         'created_by': 'user:x@chromium.org',
         'result': 'CANCELED',
@@ skipping 96 matching lines @@
         'lease_key': 42,
         'url': self.test_build.url,
     }
     res = self.call_api('start', req).json_body
     self.service.start.assert_called_once_with(
         req['id'], req['lease_key'], url=req['url'])
     self.assertEqual(int(res['build']['id']), req['id'])
     self.assertEqual(res['build']['url'], req['url'])
 
   def test_start_completed_build(self):
-    def raise_completed(*_, **__):
-      raise errors.BuildIsCompletedError()
-    self.service.start.side_effect = raise_completed
+    self.service.start.side_effect = errors.BuildIsCompletedError
     req = {
         'id': self.test_build.key.id(),
         'lease_key': 42,
     }
     res = self.call_api('start', req).json_body
     self.assertEqual(res['error']['reason'], 'BUILD_IS_COMPLETED')
 
   #################################### HEATBEAT ################################
 
   def test_heartbeat(self):
@@ skipping 208 matching lines @@
       self.assertTrue('error' in res)
       self.assertEqual(res['error']['reason'], 'INVALID_INPUT')
 
     expect_invalid_input_error(
         {'role': 'READER', 'group': 'good group'}, bucket='bad bucket')
     expect_invalid_input_error({'role': 'READER', 'group': 'bad/ group'})
 
   #################################### ERRORS ##################################
 
   def error_test(self, error_class, reason):
-    def raise_service_error(*_, **__):
-      raise error_class()
-    self.service.get.side_effect = raise_service_error
+    self.service.get.side_effect = error_class
     self.expect_error('get', {'id': 123}, reason)
 
   def test_build_not_found_error(self):
     self.error_test(errors.BuildNotFoundError, 'BUILD_NOT_FOUND')
 
   def test_invalid_input_error(self):
     self.error_test(errors.InvalidInputError, 'INVALID_INPUT')
 
   def test_invalid_build_state_error(self):
     self.error_test(errors.InvalidBuildStateError, 'INVALID_BUILD_STATE')
 
   def test_lease_expired_error(self):
     self.error_test(errors.LeaseExpiredError, 'LEASE_EXPIRED')