Chromium Code Reviews| Index: Source/core/animation/InterpolableValue.h |
| diff --git a/Source/core/animation/InterpolableValue.h b/Source/core/animation/InterpolableValue.h |
| index 61cc73ad7ac50b76207c6270e022a82eab24b026..03ada60984da6fb71ded2690ce3f29c1f8c7fe4a 100644 |
| --- a/Source/core/animation/InterpolableValue.h |
| +++ b/Source/core/animation/InterpolableValue.h |
| @@ -5,6 +5,7 @@ |
| #ifndef InterpolableValue_h |
| #define InterpolableValue_h |
| +#include "core/CoreExport.h" |
| #include "core/animation/animatable/AnimatableValue.h" |
| #include "platform/heap/Handle.h" |
| #include "wtf/OwnPtr.h" |
| @@ -13,7 +14,7 @@ |
| namespace blink { |
| -class InterpolableValue : public NoBaseWillBeGarbageCollected<InterpolableValue> { |
| +class CORE_EXPORT InterpolableValue : public NoBaseWillBeGarbageCollected<InterpolableValue> { |
| DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(InterpolableValue); |
| public: |
| virtual bool isNumber() const { return false; } |
| @@ -42,7 +43,7 @@ private: |
| friend class AnimationInterpolableValueTest; |
| }; |
| -class InterpolableNumber final : public InterpolableValue { |
| +class CORE_EXPORT InterpolableNumber final : public InterpolableValue { |
| public: |
| static PassOwnPtrWillBeRawPtr<InterpolableNumber> create(double value) |
| { |
| @@ -66,7 +67,7 @@ private: |
| }; |
| -class InterpolableBool final : public InterpolableValue { |
| +class CORE_EXPORT InterpolableBool final : public InterpolableValue { |
| public: |
| static PassOwnPtrWillBeRawPtr<InterpolableBool> create(bool value) |
| { |
| @@ -90,8 +91,10 @@ private: |
| }; |
| -class InterpolableList : public InterpolableValue { |
| +class CORE_EXPORT InterpolableList : public InterpolableValue { |
| public: |
| + InterpolableList& operator=(const InterpolableList&) = delete; |
|
haraken
2015/04/15 09:35:19
Why do we need this? It looks a bit strange that o
tasak
2015/04/16 01:28:42
The operator= is compiler-generated one. As far as
haraken
2015/04/16 03:35:10
Alternatively, would it be possible to add WTF_NON
tasak
2015/04/16 05:39:07
Unfortunately InterpolableList has its own copy co
|
| + |
| static PassOwnPtrWillBeRawPtr<InterpolableList> create(const InterpolableList &other) |
| { |
| return adoptPtrWillBeNoop(new InterpolableList(other)); |