Componentization: make core/animation,clipboard,css,dom,editing,frame,html visible for blink_web.

Componentization: make core/animation,clipboard,css,dom,editing,frame,html visible for blink_web.

https://docs.google.com/spreadsheets/d/1UYY-GIIMhsP9r2EZRAyo2NVKxftdoJsnPxiZL6nbnE8/edit?usp=sharing

BUG=358074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193874

[tasak, 2015-04-15 06:08:15]

https://codereview.chromium.org/1082293003/diff/1/Source/core/animation/Inter...
File Source/core/animation/InterpolableValue.h (right):

https://codereview.chromium.org/1082293003/diff/1/Source/core/animation/Inter...
Source/core/animation/InterpolableValue.h:94: class CORE_EXPORT InterpolableList
: public InterpolableValue {
Need to delete operator=, because of error C2248:
'WTF::OwnPtr<blink::InterpolableValue>::OwnPtr' : cannot access private member
declared in class 'WTF::OwnPtr<blink::InterpolableValue>'.

https://codereview.chromium.org/1082293003/diff/1/Source/core/animation/anima...
File Source/core/animation/animatable/AnimatableValueKeyframe.h (right):

https://codereview.chromium.org/1082293003/diff/1/Source/core/animation/anima...
Source/core/animation/animatable/AnimatableValueKeyframe.h:14: class CORE_EXPORT
AnimatableValueKeyframe : public Keyframe {
warning C4275: non dll-interface class 'blink::Keyframe' used as base for
dll-interface class 'blink::AnimatableValueKeyframe'

https://codereview.chromium.org/1082293003/diff/1/Source/core/css/CSSComputed...
File Source/core/css/CSSComputedStyleDeclaration.h (right):

https://codereview.chromium.org/1082293003/diff/1/Source/core/css/CSSComputed...
Source/core/css/CSSComputedStyleDeclaration.h:47: class CORE_EXPORT
CSSComputedStyleDeclaration final : public CSSStyleDeclaration {
non dll-interface class 'blink::CSSStyleDeclaration' used as base for
dll-interface class 'blink::CSSComputedStyleDeclaration'

https://codereview.chromium.org/1082293003/diff/1/Source/core/html/HTMLConten...
File Source/core/html/HTMLContentElement.h (right):

https://codereview.chromium.org/1082293003/diff/1/Source/core/html/HTMLConten...
Source/core/html/HTMLContentElement.h:40: class CORE_EXPORT HTMLContentElement
final : public InsertionPoint {
Need to make InsertionPoint visible to fix:
warning C4275: non dll-interface class 'blink::InsertionPoint' used as base for
dll-interface class 'blink::HTMLContentElement'

https://codereview.chromium.org/1082293003/diff/20001/Source/core/animation/I...
File Source/core/animation/InterpolableValue.h (right):

https://codereview.chromium.org/1082293003/diff/20001/Source/core/animation/I...
Source/core/animation/InterpolableValue.h:11: #include "wtf/Noncopyable.h"
No need to include wtf/Noncopyable.h.

https://codereview.chromium.org/1082293003/diff/20001/Source/core/animation/I...
Source/core/animation/InterpolableValue.h:97: InterpolableList& operator=(const
InterpolableList&) = delete;
We cannot use MAKE_WTF_NONCOPYABLE because InterpolableList has its own copy
constrcutor.
So need to delete operator= or to implement operator=.

[tasak, 2015-04-15 09:31:11]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[tasak, 2015-04-15 09:31:11]

PTAL?

[haraken, 2015-04-15 09:35:19]

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
File Source/core/animation/InterpolableValue.h (right):

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
Source/core/animation/InterpolableValue.h:96: InterpolableList& operator=(const
InterpolableList&) = delete;

Why do we need this? It looks a bit strange that only InterpolableList needs the
operator=.

https://codereview.chromium.org/1082293003/diff/40001/Source/core/css/CSSValu...
File Source/core/css/CSSValuePool.h (right):

https://codereview.chromium.org/1082293003/diff/40001/Source/core/css/CSSValu...
Source/core/css/CSSValuePool.h:91: friend CORE_EXPORT CSSValuePool&
cssValuePool();

I'm just curious but do we need EXPORT on a friend declaration?

[tasak, 2015-04-16 01:28:42]

Thank you for review.

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
File Source/core/animation/InterpolableValue.h (right):

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
Source/core/animation/InterpolableValue.h:96: InterpolableList& operator=(const
InterpolableList&) = delete;
On 2015/04/15 09:35:19, haraken wrote:
> 
> Why do we need this? It looks a bit strange that only InterpolableList needs
the
> operator=.

The operator= is compiler-generated one. As far as I understand, if some class
is dllexport-ed and the class has no copy cnostructor / no operator=, MSVC
automatically generates its copy constructor / its operator=.

This InterpolableList has
WillBeHeapVector<OwnPtrWillBeMember<InterpolableValue>> member, and OwnPtr is
not copyable. So MSVC says 'cannot access private method ...'.

https://codereview.chromium.org/1082293003/diff/40001/Source/core/css/CSSValu...
File Source/core/css/CSSValuePool.h (right):

https://codereview.chromium.org/1082293003/diff/40001/Source/core/css/CSSValu...
Source/core/css/CSSValuePool.h:91: friend CORE_EXPORT CSSValuePool&
cssValuePool();
On 2015/04/15 09:35:19, haraken wrote:
> 
> I'm just curious but do we need EXPORT on a friend declaration?

If removing CORE_EXPORT from one of cssValuePool()'s declarations, we will see:
c:\src\blink\local\workspace1\src\third_party\webkit\source\core\css\cssvaluepool.h(94)
: error C2375: 'blink::cssValuePool' : redefinition; different linkage
       
c:\src\blink\local\workspace1\src\third_party\webkit\source\core\css\cssvaluepool.h(91)
: see declaration of 'blink::cssValuePool'

[haraken, 2015-04-16 03:35:11]

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
File Source/core/animation/InterpolableValue.h (right):

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
Source/core/animation/InterpolableValue.h:96: InterpolableList& operator=(const
InterpolableList&) = delete;
On 2015/04/16 01:28:42, tasak wrote:
> On 2015/04/15 09:35:19, haraken wrote:
> > 
> > Why do we need this? It looks a bit strange that only InterpolableList needs
> the
> > operator=.
> 
> The operator= is compiler-generated one. As far as I understand, if some class
> is dllexport-ed and the class has no copy cnostructor / no operator=, MSVC
> automatically generates its copy constructor / its operator=.
> 
> This InterpolableList has
> WillBeHeapVector<OwnPtrWillBeMember<InterpolableValue>> member, and OwnPtr is
> not copyable. So MSVC says 'cannot access private method ...'.

Alternatively, would it be possible to add WTF_NON_COPYABLE to
InterpolableValue?

[tasak, 2015-04-16 05:39:07]

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
File Source/core/animation/InterpolableValue.h (right):

https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
Source/core/animation/InterpolableValue.h:96: InterpolableList& operator=(const
InterpolableList&) = delete;
On 2015/04/16 03:35:10, haraken wrote:
> On 2015/04/16 01:28:42, tasak wrote:
> > On 2015/04/15 09:35:19, haraken wrote:
> > > 
> > > Why do we need this? It looks a bit strange that only InterpolableList
needs
> > the
> > > operator=.
> > 
> > The operator= is compiler-generated one. As far as I understand, if some
class
> > is dllexport-ed and the class has no copy cnostructor / no operator=, MSVC
> > automatically generates its copy constructor / its operator=.
> > 
> > This InterpolableList has
> > WillBeHeapVector<OwnPtrWillBeMember<InterpolableValue>> member, and OwnPtr
is
> > not copyable. So MSVC says 'cannot access private method ...'.
> 
> Alternatively, would it be possible to add WTF_NON_COPYABLE to
> InterpolableValue?

Unfortunately InterpolableList has its own copy constructor, i.e. 134    
InterpolableList(const InterpolableList& other)

[haraken, 2015-04-16 07:37:29]

On 2015/04/16 05:39:07, tasak wrote:
>
https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
> File Source/core/animation/InterpolableValue.h (right):
> 
>
https://codereview.chromium.org/1082293003/diff/40001/Source/core/animation/I...
> Source/core/animation/InterpolableValue.h:96: InterpolableList&
operator=(const
> InterpolableList&) = delete;
> On 2015/04/16 03:35:10, haraken wrote:
> > On 2015/04/16 01:28:42, tasak wrote:
> > > On 2015/04/15 09:35:19, haraken wrote:
> > > > 
> > > > Why do we need this? It looks a bit strange that only InterpolableList
> needs
> > > the
> > > > operator=.
> > > 
> > > The operator= is compiler-generated one. As far as I understand, if some
> class
> > > is dllexport-ed and the class has no copy cnostructor / no operator=, MSVC
> > > automatically generates its copy constructor / its operator=.
> > > 
> > > This InterpolableList has
> > > WillBeHeapVector<OwnPtrWillBeMember<InterpolableValue>> member, and OwnPtr
> is
> > > not copyable. So MSVC says 'cannot access private method ...'.
> > 
> > Alternatively, would it be possible to add WTF_NON_COPYABLE to
> > InterpolableValue?
> 
> Unfortunately InterpolableList has its own copy constructor, i.e. 134    
> InterpolableList(const InterpolableList& other)

OK, then let's add a comment about it. LGTM.

[tasak, 2015-04-16 08:52:56]

The CQ bit was checked by tasak@google.com

[tasak, 2015-04-16 08:52:57]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1082293003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-04-16 08:53:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082293003/80001

[commit-bot: I haz the power, 2015-04-16 15:03:03]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193874