bluetooth: Impl uses new WebBluetoothGATTRemoteServer content/browser.

content/browser/bluetooth/bluetooth_dispatcher_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/bluetooth/bluetooth_dispatcher_host.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "content/common/bluetooth/bluetooth_messages.h"
 #include "device/bluetooth/bluetooth_adapter.h"
 #include "device/bluetooth/bluetooth_adapter_factory.h"
@@ skipping 18 matching lines @@
     BluetoothAdapterFactory::GetAdapter(
         base::Bind(&BluetoothDispatcherHost::set_adapter, host));
   return host;
 }
 
 bool BluetoothDispatcherHost::OnMessageReceived(const IPC::Message& message) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(BluetoothDispatcherHost, message)
   IPC_MESSAGE_HANDLER(BluetoothHostMsg_RequestDevice, OnRequestDevice)
+  IPC_MESSAGE_HANDLER(BluetoothHostMsg_ConnectGATT, OnConnectGATT)
   IPC_MESSAGE_HANDLER(BluetoothHostMsg_SetBluetoothMockDataSetForTesting,
                       OnSetBluetoothMockDataSetForTesting)
   IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 BluetoothDispatcherHost::BluetoothDispatcherHost()
     : BrowserMessageFilter(BluetoothMsgStart),
       bluetooth_mock_data_set_(MockData::NOT_MOCKING),
@@ skipping 83 matching lines @@
           false,                                         // connected
           uuids);                                        // uuids
       Send(new BluetoothMsg_RequestDeviceSuccess(thread_id, request_id,
                                                  device_ipc));
       return;
     }
   }
   NOTREACHED();
 }
 
+void BluetoothDispatcherHost::OnConnectGATT(int thread_id, int request_id,
+                                            std::string instance_id) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  BrowserThread::PostTask(BrowserThread::UI,
+                          FROM_HERE,
+                          base::Bind(
+                              &BluetoothDispatcherHost::OnConnectGATTOnUI,
+                              this, thread_id, request_id, instance_id));
+}
+
+void BluetoothDispatcherHost::OnConnectGATTOnUI(int thread_id, int request_id,
+                                                std::string instance_id) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  // TODO(ortuno): Add actual implementation of connectGATT.

[Tom Sepez, 2015/04/20 15:54:00]

Please CC me when you fix the TODO.  I'd like to make a quick check that you're
not trusting these values as sent by a renderer.

[scheib, 2015/04/20 16:50:12]

Thanks Tom, good point:

Thread and request ID are only meaningful to the renderer, the browser must just
pass them back. 

instance ID will need to be managed with care. We plan to have an "allowed
devices map"[1], as per spec, on this BluetoothDispatcherHost with device
instance IDs that have been approved for the renderer. Gio, that's something we
should put together before implementing the actual response for
OnConnectGATTOnUI.

[1] https://webbluetoothcg.github.io/web-bluetooth/#dfn-allowed-devices-map

[scheib, 2015/04/20 16:51:21]

Gio, please expand this TODO comment to clearly call out the need to check the
allowed devices map before landing this patch.

[ortuno, 2015/04/20 20:09:33]

Will do.
Done.

+  Send(new BluetoothMsg_ConnectGATTSuccess(thread_id, request_id, instance_id));
+}
+
 void BluetoothDispatcherHost::OnSetBluetoothMockDataSetForTesting(
     const std::string& name) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (name == "RejectRequestDevice_NotFoundError") {
     bluetooth_mock_data_set_ = MockData::REJECT;
     bluetooth_request_device_reject_type_ = BluetoothError::NOT_FOUND;
   } else if (name == "RejectRequestDevice_SecurityError") {
     bluetooth_mock_data_set_ = MockData::REJECT;
     bluetooth_request_device_reject_type_ = BluetoothError::SECURITY;
   } else if (name == "ResolveRequestDevice_Empty" ||  // TODO(scheib): Remove.
              name == "Single Empty Device") {
     bluetooth_mock_data_set_ = MockData::RESOLVE;
   } else {
     bluetooth_mock_data_set_ = MockData::NOT_MOCKING;
   }
 }
 
 }  // namespace content