Fix crash when removing layout managers.

Fix crash when removing layout managers.

We weren't correctly marking an element as needing style
recalc if it was *losing* it's layout manager. We were
only doing so when it was gaining a layout manager for
the first time.

Committed: https://chromium.googlesource.com/external/mojo/+/c75519ccb37e0d463efc50244bdbcbba2c34e2fc

[eseidel, 2015-04-14 20:50:37]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-04-14 20:50:37]

lgtm

[Hixie, 2015-04-14 20:53:37]

ianh@google.com changed reviewers:
+ ianh@google.com
- eseidel@chromium.org

[Hixie, 2015-04-14 20:53:38]

https://codereview.chromium.org/1082273004/diff/1/sky/engine/core/dom/Element...
File sky/engine/core/dom/Element.cpp (right):

https://codereview.chromium.org/1082273004/diff/1/sky/engine/core/dom/Element...
sky/engine/core/dom/Element.cpp:967: bool isAlreadyCustomLayout = renderer() &&
renderer()->isRenderCustomLayout();
Shouldn't this be checking callback != m_layoutManager? If the new layout
manager is the same as the old one, then presumably we don't need to be marked
dirty.

[ojan, 2015-04-14 20:55:05]

https://codereview.chromium.org/1082273004/diff/1/sky/engine/core/dom/Element...
File sky/engine/core/dom/Element.cpp (right):

https://codereview.chromium.org/1082273004/diff/1/sky/engine/core/dom/Element...
sky/engine/core/dom/Element.cpp:967: bool isAlreadyCustomLayout = renderer() &&
renderer()->isRenderCustomLayout();
On 2015/04/14 20:53:38, Hixie wrote:
> Shouldn't this be checking callback != m_layoutManager? If the new layout
> manager is the same as the old one, then presumably we don't need to be marked
> dirty.

Hmmm...this points to a different bug. If the layout managers are different,
then we need to call setNeedsLayout here. Will fix in a followup patch.

[ojan, 2015-04-14 20:57:10]

Committed patchset #1 (id:1) manually as
c75519ccb37e0d463efc50244bdbcbba2c34e2fc (presubmit successful).