Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1082263002: Move an include guard to guard all code in base/move.h (Closed)

Created:
5 years, 8 months ago by Daniel Bratell
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move an include guard to guard all code in base/move.h gcc -H warned about base/move.h missing an include guard and it was because the existing include guard didn't encompass all the code in the file. This fixes that warning and maybe makes compilations one nanosecond faster. The code outside the include guard was added Oct 2014 when fixing bug 418297. BUG=418297 Committed: https://crrev.com/e67c6972f457f8d77d3b766f4dfb598e0a7be0e9 Cr-Commit-Position: refs/heads/master@{#325132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/move.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Daniel Bratell
5 years, 8 months ago (2015-04-14 16:17:48 UTC) #2
Nico
lgtm
5 years, 8 months ago (2015-04-14 16:50:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082263002/1
5 years, 8 months ago (2015-04-14 16:51:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 21:44:45 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 21:46:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e67c6972f457f8d77d3b766f4dfb598e0a7be0e9
Cr-Commit-Position: refs/heads/master@{#325132}

Powered by Google App Engine
This is Rietveld 408576698