Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 1082253003: Make FX_NEW throw on OOM. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make FX_NEW throw on OOM. Restores default behavior of new. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ff05471b7bf9fbfeaebb3fb59468228f8cf84c63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/include/fxcrt/fx_memory.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review.
5 years, 8 months ago (2015-04-14 21:00:44 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-15 05:34:03 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-15 17:11:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff05471b7bf9fbfeaebb3fb59468228f8cf84c63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698