pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart - Issue 1082233003: suggest "this." local fields in constructor param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

Issue 1082233003: suggest "this." local fields in constructor param (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/completion/completion_test_util.dart ('k') | pkg/analysis_server/test/services/completion/optype_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

diff --git a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

index 75519795056f8aecd471fa2188ba656687af1825..35113b47741bd0dbe5c0890135b0b9f54f219740 100644

--- a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

+++ b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

@@ -47,7 +47,6 @@ class ImportedReferenceContributorTest extends AbstractSelectorSuggestionTest {

if (!(contributor as ImportedReferenceContributor).shouldWaitForLowPrioritySuggestions) {

return null;

}

- expect(request.unit.element, isNotNull);

List<CompletionSuggestion> oldSuggestions = request.suggestions;

* Simulate a source change to flush the cached compilation unit

@@ -91,6 +90,7 @@ class ImportedReferenceContributorTest extends AbstractSelectorSuggestionTest {

fail(sb.toString());

}

+ computeFastResult = null;

if (computeFast()) {

expect(request.unit.element, isNull);

assertResultsFromCache(oldSuggestions);