Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1082183003: Revert of Reland "Remove support for thread-based recompilation" (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Remove support for thread-based recompilation" (patchset #1 id:1 of https://codereview.chromium.org/1059853004/) Reason for revert: still times out Original issue's description: > Reland "Remove support for thread-based recompilation" > > Original issue's description: > > Remove support for thread-based recompilation > > > > BUG=v8:3608 > > R=yangguo@chromium.org > > LOG=y > > > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > > Cr-Commit-Position: refs/heads/master@{#27619} > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/f1ceccb8b8b352a91e6366e3e3103f1db0df6afb > Cr-Commit-Position: refs/heads/master@{#27813} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Committed: https://crrev.com/cf663c487f2d644ef6f3a5bc209c4994b91a0a56 Cr-Commit-Position: refs/heads/master@{#27816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+672 lines, -527 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 4 chunks +11 lines, -11 lines 0 comments Download
M src/isolate.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/optimizing-compile-dispatcher.h View 1 chunk +0 lines, -139 lines 0 comments Download
D src/optimizing-compile-dispatcher.cc View 1 chunk +0 lines, -351 lines 0 comments Download
A src/optimizing-compiler-thread.h View 1 chunk +166 lines, -0 lines 0 comments Download
A src/optimizing-compiler-thread.cc View 1 chunk +463 lines, -0 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Reland "Remove support for thread-based recompilation"
5 years, 8 months ago (2015-04-14 12:29:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082183003/1
5 years, 8 months ago (2015-04-14 12:29:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 12:29:33 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 12:29:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf663c487f2d644ef6f3a5bc209c4994b91a0a56
Cr-Commit-Position: refs/heads/master@{#27816}

Powered by Google App Engine
This is Rietveld 408576698