chrome/browser/about_flags.cc - Issue 1082183002: Android - Introduce "keyboard accessory" for Autofill suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 1082183002: Android - Introduce "keyboard accessory" for Autofill suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more dtrainor review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 48d8576df52e2bada55ba35d105fac803873b2d6..882ec4e7fb3c99478371e2b3e3142f1e047bbf62 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -2352,6 +2352,15 @@ const Experiment kExperiments[] = {

kOsAndroid | kOsMac | kOsWin | kOsLinux | kOsCrOS,

MULTI_VALUE_TYPE(kSupervisedUserSafeSitesChoices)

+#if defined(OS_ANDROID)

+ {

+ "enable-autofill-keyboard-accessory-view",

+ IDS_FLAGS_AUTOFILL_ACCESSORY_VIEW_NAME,

+ IDS_FLAGS_AUTOFILL_ACCESSORY_VIEW_DESCRIPTION,

+ kOsAndroid,

+ SINGLE_VALUE_TYPE(autofill::switches::kEnableAccessorySuggestionView)

+ },

+#endif // defined(OS_ANDROID)

// NOTE: Adding new command-line switches requires adding corresponding

// entries to enum "LoginCustomFlags" in histograms.xml. See note in

// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.