ui/android/java/res/drawable/autofill_accessory_view_border.xml - Issue 1082183002: Android - Introduce "keyboard accessory" for Autofill suggestions.

Side by Side Diff: ui/android/java/res/drawable/autofill_accessory_view_border.xml

Issue 1082183002: Android - Introduce "keyboard accessory" for Autofill suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more dtrainor review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h ('K') | « components/autofill/core/common/autofill_switches.cc ('k') | ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java » ('j') | ui/android/java/src/org/chromium/ui/autofill/AutofillKeyboardAccessory.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6

	7 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">
	newt (away) 2015/04/24 17:45:12 Android doesn't have a great way to draw backgroun Android doesn't have a great way to draw backgrounds with borders on only certain sides. Here's another way to do it: <inset xmlns:android="http://schemas.android.com/apk/res/android" android:insetBottom="-1dp" android:insetLeft="-1dp" android:insetRight="-1dp"> <shape android:shape="rectangle"> <stroke android:width="1dp" android:color="@android:color/black" /> <solid android:color="@android:color/white" /> </shape> </inset> What you have is fine too (just see my comment below). Also, consider using 1dp instead of 1px. 1px is almost indiscernible on an xxxhdpi device. (We should probably create @dimen/hairline for something that's usually 1px, but on super high res devices is 2px. This comes up now and then.) Evan Stade 2015/04/24 21:19:18 I've gone with your code because it's shorter. Th Show quoted text On 2015/04/24 17:45:12, newt wrote: > Android doesn't have a great way to draw backgrounds with borders on only > certain sides. Here's another way to do it: > > <inset xmlns:android="http://schemas.android.com/apk/res/android" > android:insetBottom="-1dp" > android:insetLeft="-1dp" > android:insetRight="-1dp"> > > <shape android:shape="rectangle"> > <stroke android:width="1dp" android:color="@android:color/black" /> > <solid android:color="@android:color/white" /> > </shape> > > </inset> > > What you have is fine too (just see my comment below). > > Also, consider using 1dp instead of 1px. 1px is almost indiscernible on an > xxxhdpi device. (We should probably create @dimen/hairline for something that's > usually 1px, but on super high res devices is 2px. This comes up now and then.) I've gone with your code because it's shorter. This background is temporary. It doesn't match the mocks, I just added it because I didn't want to attempt to make everything match the mocks in one go and this is the most reasonable looking background for now.
	8 <item>

	9 <shape android:shape="rectangle">

	10 <stroke android:width="1px" android:color="@android:color/black" />
	newt (away) 2015/04/24 17:45:12 Defining a <shape> without a <solid> causes troubl Defining a <shape> without a <solid> causes trouble on certain devices. They'll draw the background color as black if you don't specify anything. You can fix this by adding a <solid> element with the color set to transparent.
	11 </shape>

	12 </item>

	13 <item android:top="1px">

	14 <shape android:shape="rectangle">

	15 <solid android:color="@android:color/white"/>

	16 </shape>

	17 </item>

	18 </layer-list>

OLD	NEW