Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1082173004: Revert of Respect declared font style on Android. (Closed)

Created:
5 years, 8 months ago by jcgregorio
Modified:
5 years, 8 months ago
CC:
reviews_skia.org, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Respect declared font style on Android. (patchset #6 id:100001 of https://codereview.chromium.org/1092093002/) Reason for revert: Failed on the compile bots. Original issue's description: > Respect declared font style on Android. > > Previously the normal/italic style bit was obtained from scanning the > font file. With the new format the style may be stated explicitly, and > this explicit value in the configuration file should override any > information obtained from the font data itself. > > This change allows the font element's style attribute to override the > font's style, but retains the default 'auto' setting for backwards > compatibility. Repecting the style bit may become more important with > variation fonts, because it will be up to the configuration writer to > determine what values of the 'slnt' variation should be considered > 'normal' or 'italic'. > > DOCS_PREVIEW= https://skia.org/?cl=1092093002 > > Committed: https://skia.googlesource.com/skia/+/673e902c9b9982a167f54f1cc175d8d9cab8bcaf TBR=mtklein@google.com,tomhudson@google.com,scroggo@google.com,bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/21d3ed52e5eecc41f0ed05acdd3c5ff1189fed75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -31 lines) Patch
M site/dev/contrib/style.md View 1 chunk +4 lines, -13 lines 0 comments Download
M src/ports/SkFontConfigParser_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkFontConfigParser_android.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jcgregorio
Created Revert of Respect declared font style on Android.
5 years, 8 months ago (2015-04-17 20:30:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082173004/1
5 years, 8 months ago (2015-04-17 20:30:27 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 20:30:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/21d3ed52e5eecc41f0ed05acdd3c5ff1189fed75

Powered by Google App Engine
This is Rietveld 408576698