Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1082133002: Fix typo in Authorization header name. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.
Modified:
5 years, 8 months ago
Reviewers:
nodir
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

Fix typo in Authorization header name. This code path is not actually used yet, so the typo wasn't caught earlier. Also make sure access tokens have 'str' type, not 'unicode'. R=nodir@chromium.org BUG=356813 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M auth.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vadim Sh.
5 years, 8 months ago (2015-04-13 23:12:40 UTC) #1
nodir
lgtm
5 years, 8 months ago (2015-04-13 23:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082133002/1
5 years, 8 months ago (2015-04-13 23:23:02 UTC) #4
commit-bot: I haz the power
Presubmit check for 1082133002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-13 23:26:03 UTC) #6
Vadim Sh.
5 years, 8 months ago (2015-04-13 23:26:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 294789.

Powered by Google App Engine
This is Rietveld 408576698