chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm - Issue 108213012: [DevTools] Remove dock side knowledge from browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac tests Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

index 6b9f7c9c749d6989144f7bef8c97c7b861c94505..ff17f7df5f559246acd9f395476bede17f7185eb 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

@@ -378,8 +378,8 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,

StatusBubblePositioning) {

NSPoint origin = [controller() statusBubbleBaseFrame].origin;

- DevToolsWindow* devtools_window = DevToolsWindow::ToggleDevToolsWindow(

- browser(), DevToolsToggleAction::Show());

+ DevToolsWindow* devtools_window = DevToolsWindow::OpenDevToolsWindowForTest(

+ browser(), true);

SetDevToolsWindowContentsInsets(devtools_window, 10, 10, 10, 10);

NSPoint originWithDevTools = [controller() statusBubbleBaseFrame].origin;