chrome/browser/devtools/devtools_toggle_action.h - Issue 108213012: [DevTools] Remove dock side knowledge from browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_toggle_action.h

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac tests Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_toggle_action.h

diff --git a/chrome/browser/devtools/devtools_toggle_action.h b/chrome/browser/devtools/devtools_toggle_action.h

index 0fd5d36591da89ae2c16f4de910a3b7059358ac5..1e110a34277a8b57f1c289fe17f9b4e39b6c2564 100644

--- a/chrome/browser/devtools/devtools_toggle_action.h

+++ b/chrome/browser/devtools/devtools_toggle_action.h

@@ -16,7 +16,8 @@ struct DevToolsToggleAction {

kShowConsole,

kInspect,

kToggle,

- kReveal

+ kReveal,

+ kNoOp

};

struct RevealParams {

@@ -41,6 +42,7 @@ struct DevToolsToggleAction {

static DevToolsToggleAction Reveal(const base::string16& url,

size_t line_number,

size_t column_number);

+ static DevToolsToggleAction NoOp();

Type type() const { return type_; }

const RevealParams* params() const { return params_.get(); }