chrome/browser/devtools/devtools_embedder_message_dispatcher.h - Issue 108213012: [DevTools] Remove dock side knowledge from browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_embedder_message_dispatcher.h

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More test magic Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_embedder_message_dispatcher.h

diff --git a/chrome/browser/devtools/devtools_embedder_message_dispatcher.h b/chrome/browser/devtools/devtools_embedder_message_dispatcher.h

index a80d9459e969e91be994069da1a3df0f66913380..67795dff6b72baa826a72e378c07dfd889c023b0 100644

--- a/chrome/browser/devtools/devtools_embedder_message_dispatcher.h

+++ b/chrome/browser/devtools/devtools_embedder_message_dispatcher.h

@@ -32,6 +32,7 @@ class DevToolsEmbedderMessageDispatcher {

int top, int left, int bottom, int right) = 0;

virtual void MoveWindow(int x, int y) = 0;

virtual void SetDockSide(const std::string& side) = 0;

pfeldman 2014/01/09 12:52:01 Please comment as to-be-removed.

dgozman 2014/01/14 15:26:17 Done.

+ virtual void SetIsDocked(bool is_docked) = 0;

virtual void OpenInNewTab(const std::string& url) = 0;

virtual void SaveToFile(const std::string& url,

const std::string& content,