Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3830)

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_browsertest.cc
diff --git a/chrome/browser/task_manager/task_manager_browsertest.cc b/chrome/browser/task_manager/task_manager_browsertest.cc
index e15d82b537f0efa16e0f6bd76d2ff965c4614987..c6b13ab5b2a320b3ac9f57f4dfc1462496903888 100644
--- a/chrome/browser/task_manager/task_manager_browsertest.cc
+++ b/chrome/browser/task_manager/task_manager_browsertest.cc
@@ -513,12 +513,10 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, DISABLED_WebWorkerJSHeapMemory) {
}
IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeInTabDevToolsWindow) {
- DevToolsWindow* dev_tools = DevToolsWindow::ToggleDevToolsWindow(
+ DevToolsWindow* dev_tools = DevToolsWindow::OpenDevToolsWindow(
model()->GetResourceWebContents(1)->GetRenderViewHost(),
- true,
DevToolsToggleAction::Inspect());
- // Dock side bottom should be the default.
- ASSERT_EQ(DEVTOOLS_DOCK_SIDE_BOTTOM, dev_tools->dock_side());
+ dev_tools->SetIsDockedForTest(true);
TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
}
@@ -527,12 +525,10 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeInTabDevToolsWindow) {
IN_PROC_BROWSER_TEST_F(TaskManagerNoShowBrowserTest,
NoticeInTabDevToolsWindow) {
// First create the devtools window.
- DevToolsWindow* dev_tools = DevToolsWindow::ToggleDevToolsWindow(
+ DevToolsWindow* dev_tools = DevToolsWindow::OpenDevToolsWindow(
browser()->tab_strip_model()->GetActiveWebContents()->GetRenderViewHost(),
- true,
DevToolsToggleAction::Inspect());
- // Dock side bottom should be the default.
- ASSERT_EQ(DEVTOOLS_DOCK_SIDE_BOTTOM, dev_tools->dock_side());
+ dev_tools->SetIsDockedForTest(true);
// Make sure that the devtools window is loaded before starting the task
// manager.
content::RunAllPendingInMessageLoop();

Powered by Google App Engine
This is Rietveld 408576698