chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm - Issue 108213012: [DevTools] Remove dock side knowledge from browser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 108213012: [DevTools] Remove dock side knowledge from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More test magic Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/devtools/devtools_window.cc ('K') | « chrome/browser/task_manager/task_manager_browsertest.cc ('k') | chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm » ('j') | chrome/browser/ui/cocoa/view_id_util_browsertest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"	5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"

6	6

7 #import "base/mac/mac_util.h"	7 #import "base/mac/mac_util.h"

8 #include "base/run_loop.h"	8 #include "base/run_loop.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "chrome/browser/browser_process.h"	10 #include "chrome/browser/browser_process.h"

(...skipping 362 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
373 EXPECT_TRUE(web_contents_view->GetAllowOverlappingViews());	373 EXPECT_TRUE(web_contents_view->GetAllowOverlappingViews());

374 }	374 }

375	375

376 // Tests that status bubble's base frame does move when devTools are docked.	376 // Tests that status bubble's base frame does move when devTools are docked.

377 IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,	377 IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,

378 StatusBubblePositioning) {	378 StatusBubblePositioning) {

379 NSPoint origin = [controller() statusBubbleBaseFrame].origin;	379 NSPoint origin = [controller() statusBubbleBaseFrame].origin;

380	380

381 DevToolsWindow* devtools_window = DevToolsWindow::ToggleDevToolsWindow(	381 DevToolsWindow* devtools_window = DevToolsWindow::ToggleDevToolsWindow(

382 browser(), DevToolsToggleAction::Show());	382 browser(), DevToolsToggleAction::Show());

	383 devtools_window->SetIsDockedAndShowImmediatelyForTest(true);

383 SetDevToolsWindowContentsInsets(devtools_window, 10, 10, 10, 10);	384 SetDevToolsWindowContentsInsets(devtools_window, 10, 10, 10, 10);

384	385

385 NSPoint originWithDevTools = [controller() statusBubbleBaseFrame].origin;	386 NSPoint originWithDevTools = [controller() statusBubbleBaseFrame].origin;

386 EXPECT_FALSE(NSEqualPoints(origin, originWithDevTools));	387 EXPECT_FALSE(NSEqualPoints(origin, originWithDevTools));

387 }	388 }

OLD	NEW