[DevTools] Remove dock side knowledge from browser.

chrome/browser/ui/webui/extensions/extension_error_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_error_handler.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/location.h"
@@ skipping 179 matching lines @@
   }
 
   content::RenderViewHost* rvh =
       content::RenderViewHost::FromID(render_process_id, render_view_id);
 
   // It's possible that the render view was closed since we last updated the
   // links. Handle this gracefully.
   if (!rvh)
     return;
 
-  // Check if we already have an inspector for the given RenderViewHost. If not,
-  // create one.
-  DevToolsWindow* window =
-      DevToolsWindow::GetInstanceForInspectedRenderViewHost(rvh);
-  if (!window)
-    window = DevToolsWindow::OpenDevToolsWindow(rvh);
-
   // If we include a url, we should inspect it specifically (and not just the
   // render view).
   base::string16 url;
   if (dict->GetString(RuntimeError::kUrlKey, &url)) {
     // Line and column numbers are optional; default to the first line.
     int line_number = 1;
     int column_number = 1;
     dict->GetInteger(RuntimeError::kLineNumberKey, &line_number);
     dict->GetInteger(RuntimeError::kColumnNumberKey, &column_number);
 
     // Line/column numbers are reported in display-friendly 1-based numbers,
     // but are inspected in zero-based numbers.
-    window->Show(
+    DevToolsWindow::OpenDevToolsWindow(rvh,
         DevToolsToggleAction::Reveal(url, line_number - 1, column_number - 1));
+  } else {
+    DevToolsWindow::OpenDevToolsWindow(rvh);
   }
 
   // Once we open the inspector, we focus on the appropriate tab...
   content::WebContents* web_contents =
       content::WebContents::FromRenderViewHost(rvh);
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
   // ... but background pages have no associated browser (and the inspector
   // opens in its own window), so our work is done.
   if (!browser)
     return;
@@ skipping 18 matching lines @@
     base::DictionaryValue* results,
     int line_number,
     const std::string& contents) {
   SourceHighlighter highlighter(contents, line_number);
   highlighter.SetHighlightedRegions(results);
   web_ui()->CallJavascriptFunction(
       "extensions.ExtensionErrorOverlay.requestFileSourceResponse", *results);
 }
 
 }  // namespace extensions