Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 108213011: Make arguments to Location.assign() and .replace() non-optional (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Make arguments to Location.assign() and .replace() non-optional http://whatwg.org/html#location Firefox Nightly, IE11 Release Preview and Opera 12.16 all throw an exception when these functions are called with no argument. BUG=328194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
A LayoutTests/fast/dom/location-missing-arguments.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/location-missing-arguments-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/Location.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-13 07:00:46 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-13 07:02:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/108213011/1
7 years ago (2013-12-13 07:14:44 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-13 10:05:08 UTC) #4
Message was sent while issue was closed.
Change committed as 163852

Powered by Google App Engine
This is Rietveld 408576698