Adds TraySessionLengthLimitTest to ash_unittests.

Adds TraySessionLengthLimitTest to ash_unittests.

BUG=305812
R=bartfab@chromium.org, stevenjb@chromium.org, oshima@chromium.org
TEST=new tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240838

[stevenjb, 2013-12-12 23:30:32]

lgtm w/ a couple of suggestions

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
File ash/system/session_length_limit/tray_session_length_limit_unittest.cc
(right):

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
ash/system/session_length_limit/tray_session_length_limit_unittest.cc:52: }
Another place where MessageCenter::GetNotificationById would be handy...

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
ash/system/session_length_limit/tray_session_length_limit_unittest.cc:78: }
This should probably be a protected member of AshTestBase (since presumably that
initializes the TestSystemTrayDelegate)

[Jun Mukai, 2013-12-13 00:15:44]

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
File ash/system/session_length_limit/tray_session_length_limit_unittest.cc
(right):

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
ash/system/session_length_limit/tray_session_length_limit_unittest.cc:52: }
On 2013/12/12 23:30:32, stevenjb wrote:
> Another place where MessageCenter::GetNotificationById would be handy...

Can I do that in another CL? Several other tests use this? Possibly better to
clean them up in a single CL.

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
ash/system/session_length_limit/tray_session_length_limit_unittest.cc:78: }
On 2013/12/12 23:30:32, stevenjb wrote:
> This should probably be a protected member of AshTestBase (since presumably
that
> initializes the TestSystemTrayDelegate)

Done.

[stevenjb, 2013-12-13 01:20:08]

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
File ash/system/session_length_limit/tray_session_length_limit_unittest.cc
(right):

https://codereview.chromium.org/108213009/diff/1/ash/system/session_length_li...
ash/system/session_length_limit/tray_session_length_limit_unittest.cc:52: }
On 2013/12/13 00:15:44, Jun Mukai wrote:
> On 2013/12/12 23:30:32, stevenjb wrote:
> > Another place where MessageCenter::GetNotificationById would be handy...
> 
> Can I do that in another CL? Several other tests use this? Possibly better to
> clean them up in a single CL.

Sure, just a suggestion.

[Jun Mukai, 2013-12-13 01:20:55]

+oshima for changes in ash/test

[oshima, 2013-12-13 06:26:36]

lgtm

[commit-bot: I haz the power, 2013-12-13 08:31:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/108213009/80001

[commit-bot: I haz the power, 2013-12-13 09:31:06]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-13 19:53:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/108213009/100001

[commit-bot: I haz the power, 2013-12-13 22:12:52]

Retried try job too often on win_x64_rel for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[Jun Mukai, 2013-12-13 22:35:11]

On 2013/12/13 22:12:52, I haz the power (commit-bot) wrote:
> Retried try job too often on win_x64_rel for step(s) base_unittests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

The error says that
ash/system/session_length_limit/session_length_limit_observer.h has to have
ASH_EXPORT because its subclass TraySessionLengthLimit is referred from a
unittest.
Updated this.

[commit-bot: I haz the power, 2013-12-13 22:35:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/108213009/120001

[commit-bot: I haz the power, 2013-12-14 01:32:57]

Change committed as 240838