Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/BUILD.gn

Issue 1082123003: Rename USE_NSS to USE_NSS_CERTS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-nss-certs
Patch Set: long line Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 7a91e21e326eec7907388980cf1b1682bbbcbadc..911e471797d30f915ddff3ab4252199c6233ef11 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -126,10 +126,7 @@ config("feature_flags") {
defines += [ "USE_OPENSSL_CERTS=1" ]
}
} else if (use_nss_certs) {
- # USE_NSS really means "use nss for certificate validation and storage"
- # (like USE_OPENSSL_CERTS) and not "we're linking to NSS." It might be nice
- # to rename this but we're hoping to transition away from NSS.
- defines += [ "USE_NSS=1" ]
+ defines += [ "USE_NSS_CERTS=1" ]
Nico 2015/04/16 16:33:11 same here
davidben 2015/04/16 18:32:01 Done.
}
if (use_ozone) {
defines += [ "USE_OZONE=1" ]
« build/common.gypi ('K') | « build/common.gypi ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698