Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1082103003: Make a couple of SurfaceAggregatorPerfTests (Closed)

Created:
5 years, 8 months ago by jbauman
Modified:
5 years, 8 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make a couple of SurfaceAggregatorPerfTests These test aggregating 20 surfaces with 100 quads and resources each. Opacity < 1 in one test prevents the Surfaces from all being merged into 1 renderpass. Committed: https://crrev.com/39be201dec44e45ac25b0f467bb66f89a9085b61 Cr-Commit-Position: refs/heads/master@{#325370}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
M cc/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/debug/lap_timer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/debug/lap_timer.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
A cc/surfaces/surface_aggregator_perftest.cc View 1 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jbauman
5 years, 8 months ago (2015-04-14 22:21:45 UTC) #2
jamesr
lgtm https://codereview.chromium.org/1082103003/diff/1/cc/cc_tests.gyp File cc/cc_tests.gyp (right): https://codereview.chromium.org/1082103003/diff/1/cc/cc_tests.gyp#newcode363 cc/cc_tests.gyp:363: 'surfaces/surface_aggregator_perftest.cc', also add to cc/BUILD.gn https://codereview.chromium.org/1082103003/diff/1/cc/surfaces/surface_aggregator_perftest.cc File cc/surfaces/surface_aggregator_perftest.cc ...
5 years, 8 months ago (2015-04-15 23:59:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082103003/20001
5 years, 8 months ago (2015-04-16 00:20:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/62228)
5 years, 8 months ago (2015-04-16 00:36:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082103003/40001
5 years, 8 months ago (2015-04-16 01:16:03 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-16 01:33:14 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 01:35:07 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/39be201dec44e45ac25b0f467bb66f89a9085b61
Cr-Commit-Position: refs/heads/master@{#325370}

Powered by Google App Engine
This is Rietveld 408576698