[Chromoting] Enable remoting webapp main.html GN build.

remoting/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//remoting/remoting_version.gni")
-import("//remoting/remoting_host.gni")
+import("//remoting/remoting_enable.gni")
 import("//testing/test.gni")
 
 # Various remoting targets need this version definition.
 config("version") {
   defines = [ "VERSION=$version_full" ]
 }
 
+group("all_r") {
+  deps = [
+    #"//remoting:remoting_base",

[garykac, 2015/04/15 00:44:07]

These comments parallel the GYP file. They will be removed as we convert
targets.

[Dirk Pranke, 2015/04/15 01:08:40]

Generally I've tried to avoid having a roll-up target depend on intermediate
targets like libraries, and only depend on the "root" targets like executables.
(of course, if on some platforms you only build libraries, that's fine).

That said, I'm a bit confused; I thought that most of these targets have already
been ported?

[garykac, 2015/04/16 02:11:57]

I was keeping it in sync with the .gyp file, where we have them explicitly
mentioned, but I went ahead and removed them here.

+    #"//remoting:remoting_breakpad",
+    #"//remoting:remoting_browser_test_resources",
+    #"//remoting:remoting_client",
+    #"//remoting:remoting_client_plugin",
+    #"//remoting:remoting_protocol",
+    #"//remoting:remoting_test_common",
+    # testonly: "//remoting:remoting_unittests",
+    #"//remoting:remoting_resources",
+    #"//remoting:remoting_webapp",
+    "//remoting/webapp:html",
+    #"//remoting:remoting_webapp_unittests",
+    #"//app_remoting_test.gyp:ar_sample_test_driver",
+    #"//app_remoting_webapp.gyp:ar_sample_app",
+  ]
+
+  if (is_win) {
+    deps += [
+      #"//remoting:remoting_breakpad_tester",
+      #"//remoting:remoting_console",
+      #"//remoting:remoting_core",
+      #"//remoting:remoting_desktop",
+      #"//remoting:remoting_host_installation",
+      #"//remoting:remoting_windows_resources",
+    ]
+  }
+
+  if (is_android) {
+    deps += [
+      #"//remoting:remoting_android_client_java",
+      #"//remoting:remoting_android_resources",
+      #"//remoting:remoting_apk",
+      #"//remoting:remoting_apk_manifest",
+      #"//remoting:remoting_client_jni",
+      #"//remoting:remoting_jni_headers",
+      #"//remoting:remoting_test_apk",
+      #"//remoting:remoting_unittests_apk",
+    ]
+  }
+
+  if (enable_remoting_host) {
+    deps += [
+      # testonly: "//remoting:remoting_perftests",
+      "//remoting/host",
+      "//remoting/host:remoting_start_host",
+      "//remoting/host/it2me:remote_assistance_host",
+
+      # From .gyp:
+      #"//remoting:remoting_infoplist_strings",
+      #"//remoting:remoting_it2me_host_static",
+      #"//remoting:remoting_it2me_native_messaging_host",
+      #"//remoting:remoting_host",
+      #"//remoting:remoting_host_setup_base",
+      #"//remoting:remoting_native_messaging_base",
+      #"//remoting:remoting_native_messaging_manifests",
+      #"//remoting:remoting_perftests",
+      #"//remoting:remoting_start_host",
+    ]
+  }
+
+  if (enable_me2me_host) {
+    deps += [
+      "//remoting/host:remoting_me2me_host",
+      #"//remoting/host:remoting_me2me_host_archive",
+      #"//remoting/host:remoting_me2me_host_static",
+      #"//remoting/host:remoting_me2me_native_messaging_host",
+    ]
+  }
+}
+
+group("all_tests") {

[garykac, 2015/04/15 00:44:07]

Test targets needing to be in a separate testonly group differs from the way we
have our GYP files.

I'm probably not doing this the right way. Open to suggestions.

[Dirk Pranke, 2015/04/15 01:08:40]

Just mark the "all" target as a testonly target, and include these there (that's
what gn_all is). I would not have two separate group targets, myself.

[garykac, 2015/04/16 02:11:57]

Done.

+  testonly = true
+
+  deps = [
+    "//remoting:remoting_unittests",
+  ]
+
+  if (enable_remoting_host) {
+    deps += [ "//remoting:remoting_perftests" ]
+  }
+}
+
 # GYP version: remoting/remoting_test.gypi:remoting_test_common
 source_set("test_support") {
   testonly = true
 
   sources = [
     # Files from remoting_test_common not in separate test_support targets.
     "signaling/fake_signal_strategy.cc",
     "signaling/fake_signal_strategy.h",
     "signaling/mock_signal_strategy.cc",
     "signaling/mock_signal_strategy.h",
@@ skipping 182 matching lines @@
     }
   }
 
   group("remoting_key_tester_pexe") {
     # TODO(GYP): crbug.com/471924 implement me when we have a pnacl toolchain.
     #sources = [
     # "tools/javascript_key_tester/pnacl/remoting_key_tester.cc",
     #]
   }
 }