Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1082083004: Replace some GURL::SchemeIsSecure callers with SchemeUsesTLS. (Closed)

Created:
5 years, 8 months ago by palmer
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@origin-is-secure-gurl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace some GURL::SchemeIsSecure callers with SchemeUsesTLS. The latter is more precise, and more closely fits the semantics of these callers. BUG=362214 Committed: https://crrev.com/b075fa90786c045b2d7730f4588edd90d68afacb Cr-Commit-Position: refs/heads/master@{#325921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M chrome/browser/captive_portal/captive_portal_tab_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/content_settings/permission_context_base.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/net/certificate_error_reporter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/utility/importer/nss_decryptor.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
palmer
This CL depends on https://codereview.chromium.org/1049533002/.
5 years, 8 months ago (2015-04-15 00:23:10 UTC) #2
markusheintz_
On 2015/04/15 00:23:10, palmer wrote: > This CL depends on <crxref style="background-image: url(chrome-extension://ppnlfijacbhfpjgkafbeiaklmgoljooo/res/type/codereview.png);">https://codereview.chromium.org/1049533002/</crxref>. ContentSettings LGTM
5 years, 8 months ago (2015-04-15 15:18:14 UTC) #3
mmenke
On 2015/04/15 15:18:14, markusheintz_ wrote: > On 2015/04/15 00:23:10, palmer wrote: > > This CL ...
5 years, 8 months ago (2015-04-15 15:25:38 UTC) #4
estark
LGTM
5 years, 8 months ago (2015-04-15 17:10:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082083004/1
5 years, 8 months ago (2015-04-17 17:57:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/57198)
5 years, 8 months ago (2015-04-17 18:13:47 UTC) #9
palmer
isherman: Can you please have a look at chrome/utility/importer? Thanks!
5 years, 8 months ago (2015-04-20 20:08:04 UTC) #11
Ilya Sherman
LGTM, thanks.
5 years, 8 months ago (2015-04-20 20:58:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082083004/1
5 years, 8 months ago (2015-04-20 20:58:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 22:15:37 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 22:16:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b075fa90786c045b2d7730f4588edd90d68afacb
Cr-Commit-Position: refs/heads/master@{#325921}

Powered by Google App Engine
This is Rietveld 408576698