Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1082033002: Use prefixed URLs path when calling internal Rietveld with OAuth2 auth. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
tools
Visibility:
Public.

Description

Use prefixed URLs path when calling internal Rietveld with OAuth2 auth. Internal Rietveld exposes OAuth2 compatible API via /bots/* endpoints, not via /* as public one does. See crbug.com/476690. R=maruel@chromium.org BUG=356813 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294793

Patch Set 1 : add-internal-rietveld #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M third_party/upload.py View 5 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vadim Sh.
PTAL I'm not proud of this CL... At least a filed a bug to "fix" ...
5 years, 8 months ago (2015-04-13 20:59:31 UTC) #1
M-A Ruel
Your after life will forever be in hell for this. lgtm
5 years, 8 months ago (2015-04-14 00:55:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082033002/1
5 years, 8 months ago (2015-04-14 01:26:34 UTC) #4
commit-bot: I haz the power
Presubmit check for 1082033002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-14 01:28:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082033002/1
5 years, 8 months ago (2015-04-14 01:34:28 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 01:36:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294793

Powered by Google App Engine
This is Rietveld 408576698