Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 1082023003: Allow "::content /deep/" to match. (Closed)

Created:
5 years, 8 months ago by rune
Modified:
5 years, 8 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Allow "::content /deep/" to match. Add loop for matchForShadowDistributed to support ::content left of /deep/ combinator like we do for descendant and child combinators. R=hayato@chromium.org BUG=453437 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A LayoutTests/fast/dom/shadow/content-deep.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-deep-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
PTAL
5 years, 8 months ago (2015-04-14 11:07:59 UTC) #1
hayato
lgtm
5 years, 8 months ago (2015-04-15 04:51:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082023003/1
5 years, 8 months ago (2015-04-15 05:05:39 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 05:25:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193748

Powered by Google App Engine
This is Rietveld 408576698