Issue 1082013003: Revert of Eagerly declare eval scopes, even for sloppy scopes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1082013003: Revert of Eagerly declare eval scopes, even for sloppy scopes (Closed)

Created:
5 years, 8 months ago by marja

Modified:
5 years, 8 months ago

Reviewers:
wingo, Michael Starzinger, Toon Verwaest

CC:
v8-dev, marja, Dmitry Lomov (no reviews)

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Eagerly declare eval scopes, even for sloppy scopes (patchset #2 id:20001 of https://codereview.chromium.org/1085263003/) Reason for revert: Regresses CodeLoad (crbug.com/480774). Original issue's description: > Eagerly declare eval scopes, even for sloppy scopes > > R=marja@chromium.org, mstarzinger@chromium.org > LOG=N > BUG=N > > Committed: https://crrev.com/fe9efc121c8cba8b6aee1a9cf36c68ee97c44d99 > Cr-Commit-Position: refs/heads/master@{#28027} TBR=mstarzinger@chromium.org,verwaest@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=N Committed: https://crrev.com/b03e7a623c5090013fb9e987bb5bc44622434d2f Cr-Commit-Position: refs/heads/master@{#28037}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -13 lines)			Patch
M	src/parser.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/parser.cc	View	5 chunks	+26 lines, -4 lines	0 comments	Download
M	src/runtime/runtime-scopes.cc	View	1 chunk	+3 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

marja

Created Revert of Eagerly declare eval scopes, even for sloppy scopes

5 years, 8 months ago (2015-04-24 05:55:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082013003/1

5 years, 8 months ago (2015-04-24 05:55:36 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 05:56:03 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b03e7a623c5090013fb9e987bb5bc44622434d2f
Cr-Commit-Position: refs/heads/master@{#28037}