Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1081973003: appendHtml and insertAdjacentHtml should be consistently sanitized (Closed)

Created:
5 years, 8 months ago by Alan Knight
Modified:
5 years, 7 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

appendHtml and insertAdjacentHtml should be consistently sanitized BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=45790

Patch Set 1 #

Patch Set 2 : Add suppressions for co19 tests that rely on appendHtml #

Patch Set 3 : Two more flaky tests #

Patch Set 4 : Update signatures in SVG to match HTML #

Patch Set 5 : More co19 suppression fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -34 lines) Patch
M CHANGELOG.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 4 3 chunks +12 lines, -10 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 4 2 chunks +143 lines, -2 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 2 3 4 2 chunks +128 lines, -2 lines 0 comments Download
M tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 3 4 2 chunks +8 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Alan Knight
5 years, 8 months ago (2015-04-16 21:15:49 UTC) #2
Alan Knight
Ping
5 years, 8 months ago (2015-04-21 21:40:33 UTC) #3
terry
lgtm
5 years, 8 months ago (2015-04-21 21:53:21 UTC) #4
Alan Knight
This was committed as r45351, but it didn't seem to reflect in the issue.
5 years, 8 months ago (2015-04-22 17:18:40 UTC) #5
Alan Knight
Was also reverted. Added co19 suppressions. PTAL.
5 years, 7 months ago (2015-05-08 01:04:44 UTC) #6
terry
lgtm
5 years, 7 months ago (2015-05-11 21:35:19 UTC) #7
Alan Knight
5 years, 7 months ago (2015-05-14 18:04:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 45790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698