Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5685)

Unified Diff: chrome/installer/util/shell_util.h

Issue 108193019: Installer: adding ResolveShortcutProperties(); updating shortcut icons during shortcut migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing 'shortcut update' flow; adding unit tests for shortcut retargeting; refactoring unittests. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index 9286ae225189856d7aed6cd53c5bc99644f01373..f01184af1901ae8c60424c1c5ca7417a2d5baaa8 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -524,18 +524,20 @@ class ShellUtil {
ShellChange level,
const base::FilePath& target_exe);
- // Applies the updates in |properties| to all matching shortcuts in
- // |location|, i.e.:
- // - the shortcut's original target is |target_exe|,
+ // Updates the target of all shortcuts in |location| that satisfy the
+ // following:
+ // - the shortcut's original target is |old_target_exe|,
// - the original arguments are non-empty.
+ // If the shortcut's icon points to |old_target_exe|, then it also gets
+ // redirected to |new_target_exe|.
// Returns true if all updates to matching shortcuts are successful, including
// the vacuous case where no matching shortcuts are found.
- static bool UpdateShortcutsWithArgs(
+ static bool RetargetShortcutsWithArgs(
ShellUtil::ShortcutLocation location,
BrowserDistribution* dist,
ShellChange level,
- const base::FilePath& target_exe,
- const ShellUtil::ShortcutProperties& properties);
+ const base::FilePath& old_target_exe,
+ const base::FilePath& new_target_exe);
// Sets |suffix| to the base 32 encoding of the md5 hash of this user's sid
// preceded by a dot.

Powered by Google App Engine
This is Rietveld 408576698