Installer: adding ResolveShortcutProperties(); updating shortcut icons during shortcut migration.

base/test/test_shortcut_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/test_shortcut_win.h"
 
 #include <windows.h>
 #include <shlobj.h>
 #include <propkey.h>
 
 #include "base/files/file_path.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_propvariant.h"
 #include "base/win/windows_version.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace win {
 
-namespace {
-
-// Validates |actual_path|'s LongPathName case-insensitively matches
-// |expected_path|'s LongPathName.
 void ValidatePathsAreEqual(const base::FilePath& expected_path,
                            const base::FilePath& actual_path) {
   wchar_t long_expected_path_chars[MAX_PATH] = {0};
   wchar_t long_actual_path_chars[MAX_PATH] = {0};
 
   // If |expected_path| is empty confirm immediately that |actual_path| is also
   // empty.
   if (expected_path.empty()) {
     EXPECT_TRUE(actual_path.empty());
     return;
   }
 
   // Proceed with LongPathName matching which will also confirm the paths exist.
   EXPECT_NE(0U, ::GetLongPathName(
       expected_path.value().c_str(), long_expected_path_chars, MAX_PATH))
           << "Failed to get LongPathName of " << expected_path.value();
   EXPECT_NE(0U, ::GetLongPathName(
       actual_path.value().c_str(), long_actual_path_chars, MAX_PATH))
           << "Failed to get LongPathName of " << actual_path.value();
 
   base::FilePath long_expected_path(long_expected_path_chars);
   base::FilePath long_actual_path(long_actual_path_chars);
   EXPECT_FALSE(long_expected_path.empty());
   EXPECT_FALSE(long_actual_path.empty());
 
   EXPECT_EQ(long_expected_path, long_actual_path);
 }
 
-}  // namespace
-
 void ValidateShortcut(const base::FilePath& shortcut_path,
                       const ShortcutProperties& properties) {
   ScopedComPtr<IShellLink> i_shell_link;
   ScopedComPtr<IPersistFile> i_persist_file;
 
   wchar_t read_target[MAX_PATH] = {0};
   wchar_t read_working_dir[MAX_PATH] = {0};
   wchar_t read_arguments[MAX_PATH] = {0};
   wchar_t read_description[MAX_PATH] = {0};
   wchar_t read_icon[MAX_PATH] = {0};
@@ skipping 86 matching lines @@
           break;
         default:
           ADD_FAILURE() << "Unexpected variant type: " << pv_dual_mode.get().vt;
       }
     }
   }
 }
 
 }  // namespace win
 }  // namespace base