Don't post tasks from RulesRegistry c-tor

chrome/browser/extensions/api/declarative/rules_registry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_RULES_REGISTRY_H__
 #define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_RULES_REGISTRY_H__
 
 #include "chrome/browser/extensions/api/declarative/rules_registry.h"
 
 #include <map>
@@ skipping 47 matching lines @@
   // the UI thread) is created, a pointer to it is passed to |*ui_part|.
   // In tests, |profile| and |ui_part| can be NULL (at the same time). In that
   // case the storage functionality disabled (no RulesCacheDelegate object
   // created).
   RulesRegistry(Profile* profile,
                 const std::string& event_name,
                 content::BrowserThread::ID owner_thread,
                 RulesCacheDelegate* cache_delegate,
                 const WebViewKey& webview_key);
 
-  const OneShotEvent& ready() const {
-    return ready_;
+  // If |ready()| returns NULL, the registry does not wait for the
+  // |cache_delegate_| to initialize and can be considered ready.
+  const OneShotEvent* ready() const {
+    return (cache_delegate_) ? &ready_ : NULL;

[Fady Samuel, 2013/12/12 17:54:39]

What about making ready_ a scoped_ptr<OneShotEvent>? That way we don't actually
keep this object around in RulesRegistry if we don't need it.

[vabr (Chromium), 2013/12/13 16:03:33]

Done.

   }
 
   // RulesRegistry implementation:
 
   // Registers |rules|, owned by |extension_id| to this RulesRegistry.
   // If a concrete RuleRegistry does not support some of the rules,
   // it may ignore them.
   //
   // |rules| is a list of Rule instances following the definition of the
   // declarative extension APIs. It is guaranteed that each rule in |rules| has
@@ skipping 201 matching lines @@
   typedef std::map<ExtensionId, std::set<RuleIdentifier> > RuleIdentifiersMap;
   RuleIdentifiersMap used_rule_identifiers_;
   int last_generated_rule_identifier_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RulesRegistry);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_RULES_REGISTRY_H__