Fixing opacity for browser frame window on ASH/Windows.

chrome/browser/ui/views/chrome_views_delegate_aura.cc

Index: chrome/browser/ui/views/chrome_views_delegate_aura.cc
diff --git a/chrome/browser/ui/views/chrome_views_delegate_aura.cc b/chrome/browser/ui/views/chrome_views_delegate_aura.cc
new file mode 100644
index 0000000000000000000000000000000000000000..776887a4fc5863dae4bbb995947133c7ae45e51b
--- /dev/null
+++ b/chrome/browser/ui/views/chrome_views_delegate_aura.cc
@@ -0,0 +1,24 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/chrome_views_delegate.h"
+
+#include "chrome/browser/ui/ash/ash_util.h"
+
+views::Widget::InitParams::WindowOpacity
+ChromeViewsDelegate::GetOpacityForInitParams(
+    const views::Widget::InitParams& params) {
+  if (params.type != views::Widget::InitParams::TYPE_WINDOW &&

[sky, 2013/12/17 19:14:23]

This is the same everywhere, right? Can't we move it back to Widget?

[Shrikant Kelkar, 2013/12/17 22:43:34]

Yes we can move back, but then opacity determination logic will get again
sprinkled at multiple places.

[sky, 2013/12/17 22:58:55]

Why would it be wrong to centralize the exact same code? I'm only talking about
lines 12-14, not all of it.

[Shrikant Kelkar, 2013/12/17 23:33:29]

Done.

+      params.type != views::Widget::InitParams::TYPE_PANEL)
+    return views::Widget::InitParams::OPAQUE_WINDOW;
+
+  // We want translucent windows when either we are in ASH or we are
+  // a top level window which is not of type TYPE_WINDOW.
+  if ((params.context && chrome::IsNativeViewInAsh(params.context)) ||
+      (params.top_level && params.type !=

[sky, 2013/12/17 19:14:23]

params.top_level isn't quit the same as the old code.

[Shrikant Kelkar, 2013/12/17 22:43:34]

sorry, didn't get it?

[sky, 2013/12/17 22:58:55]

The old code considered top_level as:

    params.top_level ||
      (!params.child &&
       params.type != InitParams::TYPE_CONTROL &&
       params.type != InitParams::TYPE_TOOLTIP);

Which isn't quite the same as what you have here.

[Shrikant Kelkar, 2013/12/17 23:33:29]

params.top_level is getting reassigned immediately following this statement in
old & new code (Widget::Init) and OnBeforeWidgetInit() being called after that.
I understand that it would make GetOpacityForInitParams dependent on the fact
that params.top_level being corrected/reassigned before calling this function.
Wondering what's your suggestion? Recheck with similar condition as old one?

+          views::Widget::InitParams::TYPE_WINDOW))
+    return views::Widget::InitParams::TRANSLUCENT_WINDOW;
+
+  return views::Widget::InitParams::OPAQUE_WINDOW;
+}