Fixing opacity for browser frame window on ASH/Windows.

chrome/browser/ui/views/chrome_views_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chrome_views_delegate.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/string_util.h"
@@ skipping 156 matching lines @@
 
 views::NonClientFrameView* ChromeViewsDelegate::CreateDefaultNonClientFrameView(
     views::Widget* widget) {
 #if defined(USE_ASH)
   if (chrome::IsNativeViewInAsh(widget->GetNativeView()))
     return ash::Shell::GetInstance()->CreateDefaultNonClientFrameView(widget);
 #endif
   return NULL;
 }
 
-bool ChromeViewsDelegate::UseTransparentWindows() const {
-#if defined(USE_ASH)
-  // TODO(scottmg): http://crbug.com/133312. This needs context to determine
-  // if it's desktop or ash.
-#if defined(OS_CHROMEOS)
+bool ChromeViewsDelegate::UseTransparentWindows(
+    views::Widget::InitParams* params) const {
+  if (!params)
+    return false;
+
+  if (params->type != views::Widget::InitParams::TYPE_WINDOW &&
+      params->type != views::Widget::InitParams::TYPE_PANEL)
+    return false;
+
+// For ChromeOS we always want transparent windows.
+#if defined(USE_ASH) && defined(OS_CHROMEOS)
   return true;
-#else
-  NOTIMPLEMENTED();
+#endif
+
+// For Windows using Aura, we want transparent windows only if windows is
+// either on ASH desktop or it's top level and not of type window.
+#if defined(OS_WIN) && defined(USE_AURA)
+  if (chrome::IsNativeViewInAsh(params->context))
+    return true;
+
+  // By default, make all top-level windows but the main window transparent
+  // initially so that they can be made to fade in.
+  if (params->top_level && params->type !=
+          views::Widget::InitParams::TYPE_WINDOW)
+    return true;
+#endif
+
+  // For everything else we want opaque windows.
   return false;
-#endif
-#else
-  return false;
-#endif
 }
 
 void ChromeViewsDelegate::AddRef() {
   g_browser_process->AddRefModule();
 }
 
 void ChromeViewsDelegate::ReleaseRef() {
   g_browser_process->ReleaseModule();
 }
 
@@ skipping 103 matching lines @@
       params->native_widget = new views::DesktopNativeWidgetAura(delegate);
     }
   }
 #endif
 }
 
 base::TimeDelta
 ChromeViewsDelegate::GetDefaultTextfieldObscuredRevealDuration() {
   return base::TimeDelta();
 }